bugmonotone - Bugs: bug #9251, enhance and document 'monotone db...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9251: enhance and document 'monotone db fsck'

Submitted by:  Nathaniel Smith <njs>
Submitted on:  Mon 07 Jun 2004 10:41:34 PM UTC  
 
Category: storage systemSeverity: 1 - Wish
Item Group: feature requestStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

(Jump to the original submission Jump to the original submission)

Sat 26 Nov 2005 02:44:41 AM UTC, comment #7:

db check seems to cover this and more, and be well documented.

Daniel Carosone <uep>
Project Member
Sat 26 Nov 2005 12:44:32 AM UTC, comment #6:

monotone db check exists now.

graydon hoare <graydon>
Project Member
Sun 20 Feb 2005 05:36:19 AM UTC, comment #5:

Oh, and also:
- make sure that every revision in the database is mentioned in the revision graph
- make sure that every cert matches its stored hash
- make sure that every cert is on an existing revision
- warn if any revisions are missing any of {branch,author,date,changelog} certs.

Nathaniel Smith <njs>
Project Member
Thu 17 Feb 2005 08:15:18 AM UTC, comment #4:

It's a start. Currently, what it does is walk the cached revision graph, and make sure every revision mentioned in it is actually stored in the database.

Things it should also do:
-- make sure that the edges in the cached revision graph match the edges stored in the revisions
-- make sure that the revisions themselves are sane (call check_sane_history on every revision?)
-- make sure that mentioned files exist in the db
-- make sure that the db doesn't contain orphaned files and manifests

I think in doing this, it will necessarily check that everything has the SHA1 that it's supposed to, so that's all right...

Nathaniel Smith <njs>
Project Member
Wed 16 Feb 2005 11:11:16 PM UTC, comment #3:

I wonder if the undocumented 'db fsck' command does what you want?

Julio Merino <jmmv>
Project Member
Wed 17 Nov 2004 12:53:44 PM UTC, comment #2:

Also, verify that if a file or a manifest exists in the database, that it is referenced by some manifest or revision that also exists in the database.

Nathaniel Smith <njs>
Project Member
Wed 17 Nov 2004 09:52:41 AM UTC, comment #1:

Another thing to check, now that we have changesets: the revision graph should not have any "gaps"; if a revision foo is referred to as an ancestor of an existing revision, then foo must exist in the database.

Nathaniel Smith <njs>
Project Member
Mon 07 Jun 2004 10:41:34 PM UTC, original submission:

Monotone stores a lot of data, and it's critical to detect any corruption. We also have lots and lots of things we could use to detect corruption -- hashes everywhere, etc. Hopefully we already check a lot of things as we go, but there should be a command to systematically check everything checkable. E.g., systematically build every manifest and file mentioned in the database and verify that their SHA1's check out.

Nathaniel Smith <njs>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Sat 26 Nov 2005 12:44:32 AM UTCgraydonStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Thu 17 Feb 2005 08:15:18 AM UTCnjsSummaryadd 'monotone fsck'=>enhance and document 'monotone db fsck'

Back to the top


Powered by Savane 3.1-cleanup1