bugPEWIT - Bugs: bug #9442, typo in packet_get_addr()

 
 

bug #9442: typo in packet_get_addr()

Submitted by:  Michael Renzmann <otaku42>
Submitted on:  Thu 24 Jun 2004 09:40:18 AM UTC  
 
Severity: MinorItem Group: None
Status: NonePrivacy: Public
Assigned to: Yoshinori K. Okuji <okuji>Originator Name: 
Open/Closed: OpenRelease: 0.9.1

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Jun 2004 09:40:18 AM UTC, original submission:

packet_get_addr() is meant to retrieve the ip address of an ethernet device by issueing the appropriate ioctl() (SIOCGIFADDR). The result of the request is stored in ifr (of type struct ifreq) by ioctl(). Before the result is copied to the variable the pointer addr points to, packet_get_addr() checks if the address family of the retrieved address is correct. Now, the error is that ifr.if_broadaddr is accessed for this test rather than ifr.if_addr. This way, the test will always fail, since if_broadaddr isn't set by the ioctl SIOCGIFADDR.

This problem does not exist in tap_get_addr(), which is the equivalent of this function for tap devices.

Michael Renzmann <otaku42>
Project Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

No Changes Have Been Made to This Item

Back to the top


Powered by Savane 3.1-cleanup1