bugmonotone - Bugs: bug #9840, argc is passed as a char in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9840: argc is passed as a char in main_with_many_flavours_of_exception()

Submitted by:  Matt Johnston <mkj>
Submitted on:  Sun 01 Aug 2004 06:30:06 AM UTC  
 
Category: command line UISeverity: 3 - Normal
Item Group: crashStatus: Fixed
Privacy: PublicAssigned to: None
Open/Closed: Closed
mtn version --full: 

Tue 03 Aug 2004 05:19:07 PM UTC, comment #1:

fixed in 0.14

graydon hoare <graydon>
Project Member
Sun 01 Aug 2004 06:30:06 AM UTC, original submission:

argc is passed as a char for main_with_many_flavours_of_exception() in main.c. This breaks nastily with more than 127 arguments, as argc becomes negative. The crash can be reproduced with "monotone add *" on a dir with many (>130) files.

One-line fix:
-main_with_many_flavours_of_exception(char argc, char **argv)
+main_with_many_flavours_of_exception(int argc, char **argv)

Matt Johnston <mkj>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 03 Aug 2004 05:19:07 PM UTCgraydonOpen/ClosedOpen=>Closed
Tue 03 Aug 2004 05:19:06 PM UTCgraydonStatusNone=>Fixed

Back to the top


Powered by Savane 3.1-cleanup1