bugmldonkey, a multi-networks file-sharing client - Bugs: bug #9929, Replace...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #9929: Replace donkeyOvernet.private_address with ip..reachable

Submitted by:  spiralvoice <spiralvoice>
Submitted on:  Sun 08 Aug 2004 09:37:51 PM UTC  
 
Category: Overnet-PluginSeverity: 1 - Wish
Item Group: NoneStatus: Fixed
Assigned to: NoneOpen/Closed: Closed
Release: Release: 2-5-24
Operating System: NoneBinaries Origin: CVS / Self compiled
CPU type: None

Mon 09 Aug 2004 06:06:08 PM UTC, comment #1:

fixed in 2.5.25

mldonkey admin <mldonkey>
Project Administrator
Sun 08 Aug 2004 09:37:51 PM UTC, original submission:

From donkeyOvernet.ml
let private_address ip =
Ip.matches ip [(Ip.of_string "0.0.0.0"); (Ip.of_string "127.0.0.255");
(Ip.of_string "10.255.255.255"); (Ip.of_string "192.168.255.255") ]

From ip.ml

let reachable ip =
!allow_local_network ||
match ip with
192, 168,_,_ -> false
| 10, , , | 127, ,_,_ -> false
| 172, v, , when v > 15 && v < 32 -> false
| _ -> true

The second function is more complete, it recognizes !allow_local_network
and the 172.16.0.0-172.31.255.255 which is also private according to RFC 1918:
http://www.faqs.org/rfcs/rfc1918.html

Please also have a look at bug 7520:
http://savannah.nongnu.org/bugs/index.php?func=detailitem&item_id=7520

spiralvoice <spiralvoice>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 3 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Tue 10 Aug 2004 06:04:50 PM UTCspiralvoiceStatusNone=>Fixed
  Open/ClosedOpen=>Closed
Mon 09 Aug 2004 06:06:08 PM UTCmldonkeySeverity2 - Minor=>1 - Wish

Back to the top


Powered by Savane 3.1-cleanup1