bugmonotone - Bugs: bug #12594, [NEED TEST] \r and \n not allowed...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #12594: [NEED TEST] \r and \n not allowed in file names

Submitted by:  None
Submitted on:  Thu 07 Apr 2005 04:39:43 PM UTC  
 
Category:  None Severity:  3 - Normal
Item Group:  incorrect behavior Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
mtn version --full: 

picard:~/Documents davel$ monotone --full-version
monotone 0.17 (base revision: 337d62e5cbd50c36e2f2c2bda489a98de3a8aeb7)
Running on: Darwin 7.8.0 Darwin Kernel Version 7.8.0: Wed Dec 22 14:26:17 PST 2004; root:xnu/xnu-517.11.1.obj~1/RELEASE_PPC  Power Macintosh
Changes since base revision:

new_manifest [0152a0ae40734894b0a39501246cf4ffeada0aa4]

old_revision [337d62e5cbd50c36e2f2c2bda489a98de3a8aeb7]
old_manifest [0152a0ae40734894b0a39501246cf4ffeada0aa4]

  Generated from data cached in the distribution;
  further changes may have been made.

  Generated from data cached in the distribution;
  further changes may have been made.

  Generated from data cached in the distribution;
  further changes may have been made.

Fri 08 Apr 2005 10:00:26 PM UTC, comment #2: 

Just after mentioning this, a test for filenames with a trailing space was added.  This doesn't work on Win32, where "foo bar" appears to be an equivalent filename to "foo bar ".  This may be entirely unrelated to this bug, I'm only deducing a relationship from the IRC logs.

Either way, I figure we probably want to disallow files with trailing spaces if Win32 can't support them, or at least print a warning.

Jon Bright <sircus>
Project Member
Thu 07 Apr 2005 10:24:09 PM UTC, comment #1: 

Your problem is actually that the filename contains a carriage return (\r, ascii byte 13, as it says above).  Currently, \r and \n are not allowed in filenames.

It's possible that allowing them would be as simple as just removing them from the list of disallowed characters in constants.cc:illegal_path_bytes_arr, but we need tests to make sure that this doesn't break things, e.g. the basic_io parser for changesets.

Nathaniel Smith <njs>
Project Member
Thu 07 Apr 2005 04:39:43 PM UTC, original submission:  

While trying to import my Documents folder into a monotone database I hit this error:

monotone: misuse: bad character '13' in path component 'Icon ' of 'Older Widgets/AirPort Signal.widget/Icon '

If I get rid of that widget for Konfabulator, it trips up on others with the same problem. 

Anonymous

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-04-07 langedb Carbon-Copy- => Added dave@thelangenbergs.com
2005-04-07 njs Summaryunable to handle whitespace as the final character in a file name => [NEED TEST] \r and \n not allowed in file names

Back to the top


Powered by Savane 3.5