bugLordsAWar! - Bugs: bug #49241, Lordsawar: please make the build...

 
 

bug #49241: Lordsawar: please make the build reproducible (with patch)

Submitter:  Markus Koschany <apo>
Submitted:  Sat 01 Oct 2016 03:46:34 PM UTC
   
 
Category:  building/compilation Severity:  3 - Normal
Item Group:  0.3.0 Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Sat 22 Oct 2016 12:04:35 PM UTC, comment #9: 

Your statement that the patch works fine otherwise you wouldn't have submitted it is false.

It requires GNU Tar 1.29 which I can't accept as a minimum requirement for lordsawar because other distros simply don't have that version.

Perhaps you'd like to expand your patch to be more inclusive of Tar versions.

Ben Asselstine <benasselstine>
Group administrator
Sun 02 Oct 2016 01:13:21 PM UTC, comment #8: 

Okay here is the new release:
http://download-mirror.savannah.gnu.org/releases/lordsawar/lordsawar-0.3.1.tar.gz

Let me know if you need any last minute changes to make this work on Debian GNU/Linux.

There is a bug with the splash screen on Wayland in Fedora, I don't know if you'll experience it or not.

Ben Asselstine <benasselstine>
Group administrator
Sat 01 Oct 2016 04:24:17 PM UTC, comment #7: 

Cool!  There isn't much that's new, but what the heck.  I'll do it today or tomorrow.

Ben Asselstine <benasselstine>
Group administrator
Sat 01 Oct 2016 04:19:04 PM UTC, comment #6: 

I'm the current maintainer for Lordsawar in Debian. I would package a new release.

Markus Koschany <apo>
Sat 01 Oct 2016 04:14:03 PM UTC, comment #5: 

I find it exceptionally difficult to get anyone from Debian to do the packaging when I do a release.  Are you volunteering?

Ben Asselstine <benasselstine>
Group administrator
Sat 01 Oct 2016 04:08:24 PM UTC, comment #4: 

well it's not like there's a test suite or anything, and there's a lot of different ways this can go wrong.

ah, the scenario file just has to have the same base name as the tar file.

committing patch, although other distros might not like this syntax.

Ben Asselstine <benasselstine>
Group administrator
Sat 01 Oct 2016 04:08:15 PM UTC, comment #3: 

The GCC-6 bug is neither fixed in your latest stable release nor development release. I suggest to do another release that includes this fix.

Markus Koschany <apo>
Sat 01 Oct 2016 04:06:50 PM UTC, comment #2: 

Yes, that patch works fine otherwise I wouldn't have forwarded it.

Markus Koschany <apo>
Sat 01 Oct 2016 03:59:33 PM UTC, comment #1: 

Uh oh.  If I recall correctly, the sort order in the tar file matters...  I think the first file has to be the lordsawar scenario file, and I'm afraid if you apply that kind of sorting, it will screw that up.  I'll need some assurances that this patch actually works before committing it.

If I don't hear back in a month, this bug will be closed as non-responsive.

Ben Asselstine <benasselstine>
Group administrator
Sat 01 Oct 2016 03:46:34 PM UTC, original submission:  

Lordsawar can't be built reproducibly. I'm attaching a patch that fixes the issue. More information about the reproducible builds effort can be found at

https://wiki.debian.org/ReproducibleBuilds


Markus Koschany <apo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #38638:  reproducible-build.patch added by apo (830B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by benasselstine (Posted a comment)
  • -email is unavailable- added by apo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-02 benasselstine Open/ClosedOpen Closed
    2016-10-01 apo Attached File- Added reproducible-build.patch, #38638

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code