AVR C Runtime Library - Bugs: bug #32945, Wrong PF implementation in pmstring
You are not allowed to post comments on this tracker with your current authentication level.
bug #32945: Wrong PF implementation in pmstring
Submitter: | Thomas Kaiser <th_k> | ||
Submitted: | Tue 29 Mar 2011 06:05:42 PM UTC | ||
Category: | Library | Severity: | 5 - Blocker |
Priority: | 9 - Immediate | Item Group: | libc code |
Status: | In Progress | Assigned to: | None |
Percent Complete: | 50% | Open/Closed: | Open |
Release: | 1.7.* | Fixed Release: | None |
Wed 09 Oct 2013 01:08:19 PM UTC, comment #5: |
Pitchumani <pitchumani> |
Wed 09 Oct 2013 09:58:51 AM UTC, comment #4:
|
Pitchumani <pitchumani> |
Tue 08 Oct 2013 07:20:05 PM UTC, comment #3: If someone fixes this issue, please don't forget to reset RAMPZ to 0 after changing it. This is necessary for devices that have RAMPD. Otherwise, reading vom RAM using indirect Z addressing might read from the wrong address. For devices without RAMPD, RAMPZ need not to be reset to 0.
|
Georg-Johann Lay <gjlayde> |
Mon 26 Sep 2011 05:10:25 PM UTC, comment #2: I've changed the LPM_R0_ZPLUS_* macros in common/macros.inc to look for _AVR_HAVE_ELPM_ instead of BIG_CODE.
|
Eric Weddington <arcanum> |
Thu 15 Sep 2011 05:43:33 PM UTC, comment #1: This appears to be a consequence of the problem reported in https://savannah.nongnu.org/patch/?6352 (thus duplicate).
|
Jan Waclawek <wek> |
Tue 29 Mar 2011 06:05:42 PM UTC, original submission:
It looks like that the pmstring code uses the LPM_R0_ZPLUS_* macros von common/macros.inc, which will only use the 'elpm' if _AVR_ENHANCED_ is set. Unfortunately this is no longer used??
|
Thomas Kaiser <th_k> |
Depends on the following items: None found
Items that depend on this one: None found
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-10-09 | pitchumani | Attached File | - | Added restore-rampz.patch, #29336 | |
2012-11-16 | arcanum | Priority | 5 - Normal | 9 - Immediate | |
2011-09-26 | arcanum | Status | None | In Progress | |
2011-09-26 | arcanum | Severity | 3 - Normal | 5 - Blocker | |
Percent Complete | 0% | 50% |
Powered by Savane 3.13-3230.
Corresponding source code
RAMPZ address is hard-coded already (revision 2279) in case of building avr-libc. This resolves AVR_RAMPZ_ADDR definition error.
I have attached patch (restore-rampz.patch) to restore RAMPZ value for all xxx_PF() functions.
ChangeLog
2013-10-09 Pitchumani Sivanupandi <pitchumani.s@atmel.com>
Fix for bug #32945.
Add LPM_R0_ZPLUS_FINI macro to restore RAMPZ if RAMPD exists.
Please review.
(file #29336)