lwIP - A Lightweight TCP/IP stack - Bugs: bug #46290, Optimize passing contiguous nocopy...
You are not allowed to post comments on this tracker with your current authentication level.
bug #46290: Optimize passing contiguous nocopy buffers to tcp_write
Submitter: | Ambroz Bizjak <abizjak> | ||
Submitted: | Sun 25 Oct 2015 08:36:19 AM UTC | ||
Category: | None | Severity: | 3 - Normal |
Item Group: | Change Request | Status: | Fixed |
Privacy: | Public | Assigned to: | goldsimon |
Open/Closed: | Closed | Planned Release: | None |
lwIP version: | git head |
Jump to the original submission
Thu 24 Nov 2016 03:02:55 PM UTC, comment #6: |
David van Moolenbroek <dcvmoole> |
Thu 24 Nov 2016 10:28:33 AM UTC, comment #5: I've pushed the patch, but removed the opt.h setting making the new code active always.
|
Simon Goldschmidt <goldsimon> |
Sat 22 Oct 2016 03:11:19 PM UTC, comment #4: Attached is my edited version of the same patch. My changes compared to Ambroz's version:
|
David van Moolenbroek <dcvmoole> |
Mon 02 Nov 2015 09:51:28 PM UTC, comment #3: Hello,
|
Ambroz Bizjak <abizjak> |
Thu 29 Oct 2015 09:24:03 PM UTC, comment #2: In my opinion, this is not a scenario that needs optimization! I'd rather optimize the application than making the tcp code even more complicated.
|
Simon Goldschmidt <goldsimon> |
Sun 25 Oct 2015 08:38:39 AM UTC, comment #1: Sorry I meant "When the application is using tcp_write() without TCP_WRITE_FLAG_COPY..." |
Ambroz Bizjak <abizjak> |
Sun 25 Oct 2015 08:36:19 AM UTC, original submission:
When the application is using tcp_write() without TCP_WRITE_FLAG_MORE to send data out of a single (ring) buffer, tcp_write() will end up allocating a PBUF_ROM pbuf for each call. This can lead to lots of these pbufs being allocated when the application writes data in little chunks, and possibly we run out of pbufs in the PBUF pool (MEMP_NUM_PBUF). There is no reasonable limit on the number of pbufs that are needed in the worst case. This is an important issue because one "bad" connection can starve other connections.
|
Ambroz Bizjak <abizjak> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-11-24 | goldsimon | Status | None | Fixed | |
Open/Closed | Open | Closed | |||
2016-11-24 | goldsimon | Summary | Optimize passing contiguous buffers to tcp_write | Optimize passing contiguous nocopy buffers to tcp_write | |
2016-10-23 | dziegel | Status | Works For Me | None | |
Open/Closed | Closed | Open | |||
2016-10-22 | dcvmoole | Attached File | - | Added 0001-Add-TCP_EXTEND_ROM_PBUFS-setting-by-Ambroz-Bizjak.patch, #38795 | |
2015-10-29 | goldsimon | Item Group | Faulty Behaviour | Change Request | |
Status | None | Works For Me | |||
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2015-10-25 | abizjak | Attached File | - | Added lwip-extend-rom-pbuf.patch, #35284 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Fantastic! Thank you so much :)