bugQuilt - Bugs: bug #50061, Please allow other patch formats,...

 
 

bug #50061: Please allow other patch formats, too

Submitter:  None
Submitted:  Tue 17 Jan 2017 06:30:42 AM UTC
   
 
Category:  None Severity:  1 - Wish
Item Group:  None Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 18 Jan 2017 07:25:52 AM UTC, comment #1: 

This is an interesting idea, but it doesn't seem easy to implement properly. Quilt isn't only about calling "patch" to apply patches. It is also relying on "diff" to display the changes and to refresh patches. In the case of coccinelle, refreshing doesn't make sense. "quilt diff" should probably display the patch generated by coccinelle rather than the semantic patch.

More generally, quilt needs to know the patch format to be able to find out which files are modified by a patch, in order to backup and restore them on push and pop, respectively. But as I understand it, coccinelle patches do not include file names, as they describe generic transformations.

So you would also need a way to add the target file information, either as formatted comments in the coccinelle patch files, or maybe as extra parameters in the series file. As the user, how would you like to provide this information? In any case, this would require checking and modifying a lot of code paths in quilt.

So I don't think this generic feature request can be implemented. Specifically adding support for coccinelle may be possible, but only after defining more clearly the expectations on each quilt command for such a patch format.

Jean Delvare <khali>
Group administrator
Tue 17 Jan 2017 06:30:42 AM UTC, original submission:  

Hi,

if quilt had the ability to use different patch programs depending on the patch file extension, it would be possible to add other patch format files to a series.

For example,

    http://coccinelle.lip6.fr/

patches might be kept in the same workflow, with their default extension of ".cocci"; and while these might not be automatically refreshed, at least applying/unapplying should be easily possible.


Thanks a lot for considering this wish, and for all your efforts!


Regards,

Phil

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by khali (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-01-18 khali Severity3 - Normal 1 - Wish

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code