bugAVR Downloader/UploaDEr - Bugs: bug #57338, if safemode has to change fuses...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #57338: if safemode has to change fuses avrdude should exit with non-zero exit code

Submitter:  None
Submitted:  Sun 01 Dec 2019 11:02:58 PM UTC
   
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  joerg_wunsch Originator Name:  Britton Kerin
Originator Email:  -email is unavailable- Open/Closed:  Closed
Release:  6.3 Programmer hardware:  all
Device type:  any except AVR32, Xmega or TPI

Mon 06 Dec 2021 09:47:58 PM UTC, comment #1: 

Turns out, variable `fuses_specified' became unused in r519, but never got removed.

I dropped it now. That will hopefully resolve your report - otherwise, please re-open it.

Joerg Wunsch <joerg_wunsch>
Group administrator
Sun 01 Dec 2019 11:02:58 PM UTC, original submission:  


There's a fuses_specified variable in main that gets initialized to zero and never changed, and then there's this code at the end
of the fusemode recovery block:

    if (fuses_updated && fuses_specified) {
      exitrc = 1;
    }

So it looks like maybe the intention was to exit with non-zero if the user requested a fuse change (but fuses_specified isn't getting set in this case) but avrdude had to back it out due to fuses not being as expected.

IMO the correct thing to do is to always exit with a non-zero code if safe mode is doing any fuse recovery at all, regardless of whether any fuse changes were requested.  With some other patches that I'm about to submit this should be possible because safemode shouldn't trigger when -V is used anymore.


Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-12-06 joerg_wunsch StatusNone Fixed
        Assigned toNone joerg_wunsch
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code