patchlwIP - A Lightweight TCP/IP stack - Patches: patch #10144, use <endian.h> on Linux

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #10144: use <endian.h> on Linux

Submitter:  Florian La Roche <flaroche>
Submitted:  Mon 22 Nov 2021 08:55:49 AM UTC
 
Category:  Platform ports Priority:  3 - Low
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Planned Release:  None

Wed 22 Dec 2021 11:12:18 AM UTC, comment #3: 

Such an "ifdef _linux_" is unacceptable in our generic code. Would it work to add that include to the Linux port's cc.h and leave the rest unchanged?

Simon Goldschmidt <goldsimon>
Project Administrator
Thu 25 Nov 2021 01:08:17 PM UTC, comment #2: 

The issue was just noted by "sparse" which detects that
the endian macros get re-defined if later on <endian.h>
is included.
So this change is just a cleanup patch to use the system
header files, not fixing anything broken at all.

best regards,

Florian La Roche

Florian La Roche <flaroche>
Wed 24 Nov 2021 10:14:00 PM UTC, comment #1: 

I guess it is ctype.h normally including endian.h - but that is an optional dependency.

Can you explain more what the issue is here?

Erik Ekman <yarrick>
Project Member
Mon 22 Nov 2021 08:55:49 AM UTC, original submission:  

On Linux use <endian.h> as otherwise symbols will anyway be renamed as other headers will include <endian.h> later on.

best regards,

Florian La Roche

Florian La Roche <flaroche>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #52322:  endian.patch added by flaroche (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by yarrick (Posted a comment)
  • -email is unavailable- added by flaroche (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2021-11-22 flaroche Attached File- Added endian.patch, #52322

    Back to the top


    Powered by Savane 3.9