lwIP - A Lightweight TCP/IP stack - Patches: patch #10194, Make DHCP module more adjustable
You are not allowed to post comments on this tracker with your current authentication level.
patch #10194: Make DHCP module more adjustable
Submitter: | David Cermak <david_cermak> | ||
Submitted: | Tue 05 Apr 2022 03:25:43 PM UTC | ||
Category: | DHCP | Priority: | 5 - Normal |
Status: | None | Privacy: | Public |
Assigned to: | None | Open/Closed: | Open |
Planned Release: | None |
Jump to the original submission
Fri 12 May 2023 09:08:20 AM UTC, comment #7: |
Simon Goldschmidt <goldsimon> |
Fri 12 May 2023 08:55:00 AM UTC, comment #6: 1) Thanks for suggestion. Have reworked the patch to add this `dhcp_start_from_reboot()` API.
|
David Cermak <david_cermak> |
Thu 11 May 2023 07:04:38 PM UTC, comment #5: 3) I've took the liberty to rename the option and move it to opt.h before applying
|
Simon Goldschmidt <goldsimon> |
Thu 11 May 2023 06:31:51 PM UTC, comment #4: 1) Now I get the purpose of that hook. Instead of making it too generic, shouldn't we rather make it explicit and let the hook provide what's required to request the old address? Because the way your example code looks, you're making the application depend on lwIP internals and there's a very high risk that your hook won't work with the next version of lwIP when internals have changed.
|
Simon Goldschmidt <goldsimon> |
Thu 11 May 2023 05:41:25 PM UTC, comment #3: 4) Renamed to DHCP_ADD_EXTRA_REQUEST_OPTIONS and documented with an example |
David Cermak <david_cermak> |
Thu 11 May 2023 05:40:22 PM UTC, comment #2: Updated per review:
|
David Cermak <david_cermak> |
Wed 10 May 2023 07:44:59 PM UTC, comment #1: Let me respond to each patch:
|
Simon Goldschmidt <goldsimon> |
Tue 05 Apr 2022 03:25:43 PM UTC, original submission:
Adding 4 separate patches, that should enable users to redefine or adjust various DHCP parameters per specific port needs. (to support some changes in the Espressif's fork: https://github.com/espressif/esp-lwip)
|
David Cermak <david_cermak> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2023-05-12 | david_cermak | Attached File | - | Added 0001-Fix2-dhcp-Add-dhcp_start_from_reboot-API-to-start-DHCP-wi.patch, #54733 | |
Attached File | - | Added 0004-Fix2-dhcp-docs-Fix-doxygen-build-to-mark-define-in-commen.patch, #54734 | |||
2023-05-11 | david_cermak | Attached File | - | Added 0004-Fix1-dhcp-Add-macro-for-appending-extra-client-s-request-.patch, #54726 | |
2023-05-11 | david_cermak | Attached File | - | Added 0001-Fix1-dhcp-Add-post_init-hook-to-allow-for-skipping-discov.patch, #54722 | |
Attached File | - | Added 0002-Fix1B-dhcp-Enable-custom-config-for-timeouts-thresholds-ba.patch, #54723 | |||
Attached File | - | Added 0002-Fix1A-dhcp-Move-in-place-timeout-threshold-calculations-to.patch, #54724 | |||
Attached File | - | Added 0003-Fix1-dhcp-Set-hostname-for-DISCOVER-packets.patch, #54725 | |||
2022-04-05 | david_cermak | Attached File | - | Added 0001-dhcp-Add-post_init-hook-to-allow-for-skipping-discov.patch, #53045 | |
Attached File | - | Added 0003-dhcp-Set-hostname-for-DISCOVER-packets.patch, #53046 | |||
Attached File | - | Added 0002-dhcp-Enable-custom-config-for-timeouts-thresholds-ba.patch, #53047 | |||
Attached File | - | Added 0004-dhcp-Add-hook-for-appending-extra-client-s-request-o.patch, #53048 |
Powered by Savane 3.13-f8d8.
Corresponding source code
1) Adding a hook for configuration is not a bad thing. But in this case, I think it might be a more common need to restore an address after rebooting. So I'd rather have that explicitly than "hiding" it in a hook + comment, that's all.
4) Thanks for checking doxygen. I should have seen that myself on the github runner results...