patchConcurrent Versions System - Patches: patch #4919, wd-sanity.sh with pserver support

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4919: wd-sanity.sh with pserver support

Submitter:  Rahul Bhargava <b_rahul>
Submitted:  Sat 18 Feb 2006 03:10:24 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Fixed Release:  None Fixed Feature Release:  None

Thu 23 Feb 2006 04:16:23 PM UTC, comment #4: 

I am personally not as worried about applying changes to the test suite to stable even when they don't just fix bugs.  Something like this, which should expand testing and thus possibly out new bugs in stable, especially, I would find acceptable.

Derek Robert Price <dprice>
Group administrator
Sun 19 Feb 2006 04:37:00 AM UTC, comment #3: 

If you already have a patch against the
cvs1-11-x-branch, then we might as well
start with that one.

Please attach a set of unified diffs to
this patch report if you are willing to
release the new tests under the GPL
license for inclusion with a future CVS
release.

Mark D. Baushke <mdb>
Group administrator
Sun 19 Feb 2006 04:36:08 AM UTC, comment #2: 

Date: Sat, 18 Feb 2006 20:21:21 -0800
From: Rahul Bhargava <rahul@wandisco.com>

Mark D. Baushke wrote:

> Follow-up Comment #1, patch #4919 (project cvs):
>
> I do not know what wd-sanity.sh is. There is no current one in
> the CVS sources to patch. Is this the 'WanDisco' sanity.sh ?
>
>

I am sorry I meant sanity.sh with pserver test changes

> The addition of tests for src/sanity.sh to test features of cvs
> will be of interest and considered for inclusion into official
> suite.
>
> Note: It is highly desirable that such tests fit in with the
> existing framework rather than being a separate script. It is
> also a goal that it be portable to as many platforms as possible.
>
>

Its the same script (sanity.sh) with pserver related changes.

> For what it may be worth, patches to the FEATURE branch will
>


Its off the 1.11.21 branch right now. It would make sense to
test pserver support on both stable and feature branches in
my opinion.

> be adopted more readily than those to STABLE branch.


Mark D. Baushke <mdb>
Group administrator
Sat 18 Feb 2006 04:40:17 PM UTC, comment #1: 

I do not know what wd-sanity.sh is. There is no current one in
the CVS sources to patch. Is this the 'WanDisco' sanity.sh ?

The addition of tests for src/sanity.sh to test features of cvs
will be of interest and considered for inclusion into official
suite.

Note: It is highly desirable that such tests fit in with the
existing framework rather than being a separate script. It is
also a goal that it be portable to as many platforms as possible.

For what it may be worth, patches to the FEATURE branch will
be adopted more readily than those to STABLE branch.

Mark D. Baushke <mdb>
Group administrator
Sat 18 Feb 2006 03:10:24 AM UTC, original submission:  

Hi -

Before I take the trouble of submitting the actual patch, wanted to check with the CVS maintainers if they will be interested in a patch that enhances the current wd-sanity.sh to work with pserver protocol as well.

It is strange that a supported and popular protocol is not part of regular test process. I know there are some who do not like pserver because of its security implications yet it is used in the field, so why not test it?

When we enhanced the wd-sanity.sh we did see several tests behave differently under pserver protocol.

Let us know if you are interested.

--
Rahul Bhargava,
SCM Solutions
WANdisco,Inc.
Pleasanton, CA
http://www.wandisco.com

Rahul Bhargava <b_rahul>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follows 1 latest change.

Date Changed by Updated Field Previous Value => Replaced by
2006-02-18 b_rahul Carbon-Copy- Added -email is unavailable-

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code