patchmldonkey, a multi-networks file-sharing client - Patches: patch #5496, BT: Do not remove good clients...


You are not allowed to post comments on this tracker with your current authentication level.

patch #5496: BT: Do not remove good clients (experimental)

Submitter:  spiralvoice <spiralvoice>
Submitted:  Thu 26 Oct 2006 11:02:09 PM UTC
Category:  Bug fixes Priority:  7 - High
Status:  Ready For Test Assigned to:  None
Open/Closed:  Open

Jump to the original submission

Sat 10 Apr 2010 09:39:47 PM UTC, comment #6: 

Problem with memory usage - 4 days of uptime and RSS steadily grows, from 40M to 200M now.

ygrek <ygrek>
Group Member
Fri 09 Apr 2010 08:23:14 PM UTC, comment #5: 

With this patch it becomes pretty obvious that some pagination is needed when listing clients in html ui (and probably some way to limit the output in telnet interface?). This is also an easy way to resolve bug #17712

ygrek <ygrek>
Group Member
Mon 05 Apr 2010 08:37:30 PM UTC, comment #4: 

I didn't observe the error messages reported by bogeyman with this patch.
But got another message - exn Out_of_memory in disconnect_client. Solution - use List2.removeq instead of List2.remove, and probably List.remove should use compare instead of (=) ...

(file #20122)

ygrek <ygrek>
Group Member
Sun 04 Apr 2010 10:24:47 PM UTC, comment #3: 

Refreshed for current CVS.

(file #20117)

ygrek <ygrek>
Group Member
Fri 17 Nov 2006 03:42:10 PM UTC, comment #2: 

will try this:
-            remove_client c;
+         current_uploaders := List2.remove c !current_uploaders;
+          c.client_received_peer_id <- false;

Another issue: I got ~25000 CommonClients but only 100 DonkeyClients, long after my bt download finished and i dont upload anymore to bt clients.

bogeyman <bogeyman>
Group Member
Fri 17 Nov 2006 03:29:24 PM UTC, comment #1: 

I got a lot of "BT: Unknown message" & "btprotocol.bt_handler: closed connection" and the dumps indicate that they send their ID but c.client_received_peer_id is set. have it to be set to false at some point, where we dont remove the peer?!

Cannot test it and hope this helps

bogeyman <bogeyman>
Group Member
Thu 26 Oct 2006 11:02:09 PM UTC, original submission:  

Please test this experimental patch.
Its aim is to solve the problem that BT clients disappear too quickly.
Some debug code is still present, please ignore its output in logfile.

spiralvoice <spiralvoice>
Group administrator


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20122:  good_clients2.diff added by ygrek (12KiB - text/x-diff)
file #20117:  good_clients.diff added by ygrek (12KiB - text/x-diff)
file #12227:  5496.patch added by spiralvoice (13KiB - text/x-diff)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by ygrek (Updated the item)
  • -email is unavailable- added by spiralvoice (Updated the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-04-08 spiralvoice Priority5 - Normal 7 - High
        StatusPostponed Ready For Test
    2010-04-05 ygrek Attached File- Added good_clients2.diff, #20122
    2010-04-04 ygrek Attached File- Added good_clients.diff, #20117
    2007-03-21 spiralvoice Attached File- Added 5496.patch, #12227
    2007-03-21 spiralvoice Attached File#11094 Removed
    2006-11-29 spiralvoice StatusIn Progress Postponed
    2006-10-27 spiralvoice Attached File- Added bt.patch, #11094
    2006-10-27 spiralvoice Attached File#11084 Removed
    2006-10-26 spiralvoice Attached File- Added bt.patch, #11084

    Back to the top

    Powered by Savane 3.12.
    Corresponding source code