patchTransport Sample Protocol - Patches: patch #6667, Fix endianness problem

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #6667: Fix endianness problem

Submitter:  MARTINSONS <martinsons>
Submitted:  Mon 10 Nov 2008 01:44:18 PM UTC
   
 
Category:  TSP Priority:  5 - Normal
Status:  Ready For Test Privacy:  Public
Assigned to:  erk Open/Closed:  Open

Jump to the original submission

Wed 12 Nov 2008 12:33:10 PM UTC, comment #11: 

Ok just checked-in CVS.

Eric NOULARD <erk>
Group administrator
Wed 12 Nov 2008 11:50:25 AM UTC, comment #10: 

I don't think it's necessary to make a diff, I do nothing in paricular, I just replace the line :

IF(CMAKE_SYSTEM_NAME STREQUAL "Linux") by
IF(CMAKE_SYSTEM_NAME STREQUAL "Linux" OR CMAKE_SYSTEM_NAME STREQUAL "SunOS")


MARTINSONS <martinsons>
Wed 12 Nov 2008 10:38:48 AM UTC, comment #9: 

OK nice, thank you for testing.
SunOS case should be handled the same way as Linux one
(rpcgen exists and is working fine)
Would you send me a diff file for your
ONCRPC_SETUP
and I will check-in the change.

you may generate such diff with command like:


diff -u FindONCRPC.cmake FindONCRPC.cmake.modified > FindONCRPC.patch


then upload the file in this tracker.

Eric NOULARD <erk>
Group administrator
Wed 12 Nov 2008 09:55:59 AM UTC, comment #8: 

OK, it works fine for Solaris (sparc) and Linux (i686, 32 bits I think).

There wad just a little problem on Solaris, there was no SunOS case in the macro ONCRPC_SETUP, so I added it.

Fred.

MARTINSONS <martinsons>
Mon 10 Nov 2008 06:34:54 PM UTC, comment #7: 
Eric NOULARD <erk>
Group administrator
Mon 10 Nov 2008 03:37:47 PM UTC, comment #6: 

:) 
 
As you guessed, I can't connect to the cvs server...

MARTINSONS <martinsons>
Mon 10 Nov 2008 03:31:05 PM UTC, comment #5: 


> When you have a modified tsp CVS tree you may create a patch
> using:


> cd tsp_HEAD
> cvs -u > /path/to/my_beautiful.patch


Small typo here, the last line should read:
cvs diff -u > /path/to/my_beautiful.patch

Regards,
Frederik

Frederik Deweerdt <deweerdt>
Group administrator
Mon 10 Nov 2008 03:15:09 PM UTC, comment #4: 

No stupid question.
You have valuable help here:
https://savannah.nongnu.org/cvs/?group=tsp

Since you are not [yet] a registered TSP project developer
you should use anonymous access:

cvs -z3 -d:pserver:anonymous@cvs.savannah.nongnu.org:/sources/tsp co -dtsp_HEAD tsp

this will automatically take (checkout in CVS wording)
the most up to date version of tsp in the tsp_HEAD directory.
[note that the pserver protocol uses tcp port 2401
 which is sometimes blocked by enterprise firewall
 if you have firewall trouble I'll try to generate a
 downloadable tarball for you]

After that you may build TSP with CMake as usual.

once you have your pristine TSP tree you may apply the patch this way:

cd tsp_HEAD
patch -p0 < /path/to/bug24797-EndianPb-tsp0_8_3.patch

then recompile and test.

When you have a modified tsp CVS tree you may create a patch
using:

cd tsp_HEAD
cvs -u > /path/to/my_beautiful.patch

Patch are easier to handle than whole file because
they are easier to merge when working with different
TSP version.


Eric NOULARD <erk>
Group administrator
Mon 10 Nov 2008 03:07:40 PM UTC, comment #3: 

Stupid question : I never used CVS before so how can I get CVS head version ?
Thanks

MARTINSONS <martinsons>
Mon 10 Nov 2008 02:54:14 PM UTC, comment #2: 

I have generated a patch against 0.8.3
which appears to works fine with CVS HEAD.

It works for me on a single x86_64 host
but I would like others to test this
mixed endian setup.

Frederic would you be able to test this patch
using CVS HEAD version of TSP?

Eric NOULARD <erk>
Group administrator
Mon 10 Nov 2008 02:18:06 PM UTC, comment #1: 

I will have a look at your change.
Thank you.

Eric NOULARD <erk>
Group administrator
Mon 10 Nov 2008 01:44:18 PM UTC, original submission:  


Following the bug #24797.

I've just changed the order of adress parts and remove ntohl function.I've joined the 3 concerned files.

MARTINSONS <martinsons>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #16816:  bug24797-EndianPb-tsp0_8_3.patch added by erk (4KiB - text/x-diff - TSP_0_8_3 patch (works with current HEAD))
file #16814:  tsp_server.c added by martinsons (13KiB - text/x-csrc)
file #16815:  tsp_stream_sender.c added by martinsons (15KiB - text/x-csrc)

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by deweerdt (Posted a comment)
  • -email is unavailable- added by erk (Posted a comment)
  • -email is unavailable- added by martinsons (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-11-12 erk StatusIn Progress Ready For Test
    2008-11-10 erk Attached File- Added bug24797-EndianPb-tsp0_8_3.patch, #16816
    2008-11-10 erk StatusNone In Progress
        Assigned toNone erk
    2008-11-10 erk StatusNone In Progress
        Assigned toNone erk
        Dependencies- Depends on bugs #24797
    2008-11-10 martinsons Attached File- Added tsp_check_host_and_ip.c, #16813
        Attached File- Added tsp_server.c, #16814
        Attached File- Added tsp_stream_sender.c, #16815

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code