patchWeeChat - Patches: patch #6989, Patch for the ruby plugin to...

 
 

patch #6989: Patch for the ruby plugin to support ruby 1.9.1 (in addition to 1.8)

Submitted by:  Dominik Honnef <dominikh>
Submitted on:  Sat 21 Nov 2009 02:33:18 AM UTC  
 
Category:  script plugin Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  Sebastien Helleu <flashcode> Open/Closed:  Closed
IRC nick:  dominikh

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Fri 11 Dec 2009 12:26:08 AM UTC, comment #6: 

support (actually a bugfix) for encodings in ruby 1.9

(file #19238)

Dominik Honnef <dominikh>
Wed 02 Dec 2009 02:17:38 PM UTC, comment #5: 

added support for rubygems

(file #19184)

Dominik Honnef <dominikh>
Sun 29 Nov 2009 03:13:06 PM UTC, comment #4: 

further improvements

(file #19151)

Dominik Honnef <dominikh>
Wed 25 Nov 2009 05:37:25 PM UTC, comment #3: 

Okay, it's all done, see the latest added patch.

(file #19133)

Anonymous
Sun 22 Nov 2009 02:50:09 AM UTC, comment #2: 

The plugin also seems to be broken with regard to printing the exceptions. I guess this should be put on hold until I fixed that, at least.

Dominik Honnef <dominikh>
Sat 21 Nov 2009 10:23:13 PM UTC, comment #1: 

Okay, looks like this patch has one drawback... Ruby 1.9.1 segfaults (and thus kills weechat) if the ruby plugin is being unloaded (which also happens when weechat is being quitted).

The only solution, as it seems to me, is a patch to Ruby 1.9.1 which is currently being discussed, and as such won't make its way to the average user too quickly.

It is up to you if you want to merge this patch and forbid unloading (ugh), or if you don't. Maybe you can also find a way of rescueing the crash.

Dominik Honnef <dominikh>
Sat 21 Nov 2009 02:33:18 AM UTC, original submission:  

A patch for the ruby plugin to support ruby 1.9.1 in addition to 1.8, even though the last point has to be tested by someone who actually uses 1.8 -- but I am very confident.

The patch was created using git-format-patch and can thus be easily applied.

Dominik Honnef <dominikh>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by dominikh (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 12 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-01-23 flashcode Open/ClosedOpen => Closed
    2009-12-11 dominikh Attached File- => Added 0001-encoding-support-for-ruby-1.9.patch, #19238
    2009-12-02 dominikh Attached File- => Added 0001-made-rubygems-optional.patch, #19187
    2009-12-02 dominikh Attached File- => Added 0001-patched-ruby-plugin-to-work-with-rubygems-fixed-exce.patch, #19185
    2009-12-02 dominikh Attached File- => Added 0001-patched-ruby-plugin-to-work-with-rubygems-fixed-exce.patch, #19184
    2009-11-29 flashcode Categoryplugins => script plugin
        StatusNone => Done
        Assigned toNone => flashcode
    2009-11-29 dominikh Attached File- => Added 0001-further-improvements-to-the-ruby-plugin.patch, #19151
    2009-11-25 None Attached File- => Added 0001-patched-ruby-plugin-to-support-both-ruby-1.8-and-1.9.patch, #19133
    2009-11-21 dominikh Attached File- => Added 0001-nicer-formatting-of-ruby-exceptions.patch, #19103
    2009-11-21 dominikh Attached File- => Added 0001-fixing-ruby-plugin-so-it-works-with-ruby-1.9.1-too.patch, #19097

    Back to the top


    Powered by Savane 3.5