patchThe FreeType Project - Patches: patch #7290, Don't use the LIBTOOL from the...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7290: Don't use the LIBTOOL from the environment

Submitter:  Adrian Bunk <bunk>
Submitted:  Wed 25 Aug 2010 01:15:49 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  mpsuzuki Open/Closed:  Closed

Jump to the original submission

Tue 31 Aug 2010 09:23:02 AM UTC, comment #6: 

Thank you for very quick reply! Soon I will commit the patch to GIT head.

suzuki toshiya <mpsuzuki>
Group administrator
Tue 31 Aug 2010 09:09:59 AM UTC, comment #5: 

Thanks, works for me.

Adrian Bunk <bunk>
Tue 31 Aug 2010 08:39:53 AM UTC, comment #4: 

Attached is a patch based on the suggestion by Werner.
Adrian, this is OK? Yet I could not reproduce the problem
you found, so I'm not sure if it fits your purpose.
I guess you feel it's not enough (because the style is
not exactly same with standard autoconfized software),
it is just to avoid the reference of external LIBTOOL
variable.

(file #21358)

suzuki toshiya <mpsuzuki>
Group administrator
Mon 30 Aug 2010 04:48:27 AM UTC, comment #3: 

Perhaps

  s/LIBTOOL/LIBTOOL_DIR/

in FreeType is sufficient?

Werner LEMBERG <wl>
Group administrator
Mon 30 Aug 2010 03:02:30 AM UTC, comment #2: 

The reason why LIBTOOL in unix-cc.in is defined by "?="
seems to be related with the directory structure of FreeType2
source code. The configure script in the top directory is
not by autoconf, it is a meta-configure to execute builds/
unix/configure. When it is executed out of the source
directory (e.g. configure & build the source code in CD-ROM
and build directory is HDD), configure in the top_directory
generates a meta-Makefile which defines non-default value
for LIBTOOL (:= $(OBJ_DIR)/libtool).

I will reconsider how to improve it. I have to work other
crashing issue, please wait. I'm sorry.


suzuki toshiya <mpsuzuki>
Group administrator
Sun 29 Aug 2010 07:05:58 AM UTC, comment #1: 

Thanks, your request sounds reasonable for me, because
other values configured by autoconf (CC, EXEEXT,
CPPFLAGS, LDFLAGS etc) are defined by ":=".
Only "LIBTOOL" is defined by "?=". Using ":=" for
LIBTOOL may improve the consistency in FreeType2.

I will check the history why LIBTOOL is defined by
"?=", please wait a while.

suzuki toshiya <mpsuzuki>
Group administrator
Wed 25 Aug 2010 01:15:49 AM UTC, original submission:  

There was a build error with the system libtool for me, and there's no reason to use a system libtool at all even if LIBTOOL is set in the environment: There's always the working libtool that gets created during the build.

That's also consistent with the behavior of software using automake.

Adrian Bunk <bunk>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #21358:  fix-LIBTOOL-make-var.diff added by mpsuzuki (1KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by wl (Posted a comment)
  • -email is unavailable- added by mpsuzuki (Posted a comment)
  • -email is unavailable- added by bunk (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-08-31 mpsuzuki StatusNone Done
        Open/ClosedOpen Closed
    2010-08-31 mpsuzuki Attached File- Added fix-LIBTOOL-make-var.diff, #21358
    2010-08-29 mpsuzuki Assigned toNone mpsuzuki
    2010-08-25 bunk Attached File- Added 0001-Don-t-use-the-LIBTOOL-from-the-environment.patch, #21294

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code