patchmldonkey, a multi-networks file-sharing client - Patches: patch #7309, GUI protocol: add opcode to...


You are not allowed to post comments on this tracker with your current authentication level.

patch #7309: GUI protocol: add opcode to retrieve servers list

Submitter:  ygrek <ygrek>
Submitted:  Tue 07 Sep 2010 08:56:55 PM UTC
Category:  Improved interfaces Priority:  5 - Normal
Status:  Need Info Assigned to:  None
Open/Closed:  Open

Mon 13 Sep 2010 04:37:37 PM UTC, comment #5: 

In HTML interface there exists a column "P". Also the option ED2K-connect_only_preferred_server should be made a global option to be used by DC as well.
For displaying large HTML content see bug #17712.

spiralvoice <spiralvoice>
Group administrator
Sun 12 Sep 2010 09:24:50 PM UTC, comment #4: 

Ok, I will move hublist to CommonServers and see whther it is usable - browser will have a hard time coping with 1.5k entries table, also the question is how the chosen/favorite servers are distinguished in this list.

ygrek <ygrek>
Group Member
Wed 08 Sep 2010 07:57:43 PM UTC, comment #3: 

"GuiServerInfo is for connected/chosen servers only."

Afair no, my EDK server list shows all known servers, regardless of connection state. But now I remember my IRC log from 2007 (long time ago...) on the Wiki from my talk with the original coder of the DC++ code:

Apr 30 22:08:41 <Alffa> if you list the hublist there is add button
Apr 30 22:09:00 <Alffa> when yuou add the hub it shows in global servers list
Apr 30 22:10:44 <spiralvoice> Alffa: I added 8 hubs, thry are all in state waiting now, should I add more hubs?
Apr 30 22:11:19 <Alffa> the "waiting" means that the server/hub is like in your favourites list and doing nothing
Apr 30 22:12:21 <Alffa> you have to connect to it from global server ist and if it connects it shows in global servers list "connected" and in dc hub list "user" or "op"
Apr 30 22:13:08 <Alffa> there is no limit for hubs, you can add as meny you think are usable to you
Apr 30 22:13:16 <Alffa> like favourites list ...

This means DC++ has a second list of servers, outside CommonServer, where a loaded hublist is stored first. From there you have to manually add a server (aka hub) to CommonServer and use it.
Now I understand the problem you want to solve, but I do not think having a second server list, specific to one network, is such a good idea.
Did you already talk to zet (Sancho maintainer) about your proposal?
Or did you try storing a hublist directly in CommonServer? G2 and Fasttrack work that way and I do not remember performance problems with hundreds of servers.

spiralvoice <spiralvoice>
Group administrator
Wed 08 Sep 2010 07:28:20 PM UTC, comment #2: 

GuiServerInfo is for connected/chosen servers only. This list is intended to be presented to user to choose servers from - e.g. dchublist contains the list of all known public DC hubs (currently 1500) - for now this list is only accessible via webui or telnet. I was thinking of reusing Server_info fir this too but then it would have contained many dummy values and so I have chosen more free-form structure. Maybe a better name should be used.

ygrek <ygrek>
Group Member
Wed 08 Sep 2010 04:39:44 PM UTC, comment #1: 

What is the purpose of this patch?

All servers present are currently sent by update_gui_info() to the GUI which then can distinguish servers by their network identifier:

spiralvoice <spiralvoice>
Group administrator
Tue 07 Sep 2010 08:56:55 PM UTC, original submission:  

currently implemented for DC

(this and previous patches are from dev/3.0.5 branch from the git repo)

ygrek <ygrek>
Group Member


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #21408:  gui_serverslist.diff added by ygrek (11KiB - text/x-patch)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Posted a comment)
  • -email is unavailable- added by ygrek (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-09-08 spiralvoice CategoryNone Improved interfaces
        StatusNone Need Info
    2010-09-07 ygrek Attached File- Added gui_serverslist.diff, #21408

    Back to the top

    Powered by Savane 3.13-6ae7.
    Corresponding source code