patchmldonkey, a multi-networks file-sharing client - Patches: patch #7798, restore OSX compatibility

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7798: restore OSX compatibility

Submitter:  nibbles <github_2bits>
Submitted:  Sat 23 Jun 2012 11:25:12 AM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Assigned to:  ygrek
Open/Closed:  Closed

Sun 24 Jun 2012 08:02:43 AM UTC, comment #5: 

committed 2012/06/24

spiralvoice <spiralvoice>
Group administrator
Sat 23 Jun 2012 11:26:07 AM UTC, comment #4: 
spiralvoice <spiralvoice>
Group administrator
Sat 23 Jun 2012 11:25:12 AM UTC, comment #3: 

This item has been reassigned from the project mldonkey, a multi-networks file-sharing client bugs tracker to your tracker.

The original report is still available at bugs #36654

Following are the information included in the original report:

[field #0]                  Item ID: 36654
[field #1]                 Group ID: 1409
[field #2]              Open/Closed: Open
[field #3]                 Severity: 3 - Normal
[field #4]                  Privacy: Public
[field #8]                         : Unknown bugs Field Display Type
[field #9]                 Category: Core
[field #10]             Submitted by: github_2bits
[field #11]              Assigned to: None
[field #12]             Submitted on: Do 14 Jun 2012 04:44:25 CEST
[field #13]                  Summary: restore OSX compatibility
[field #14]      Original Submission: Reporting this for Homebrew a package installer for Macs.

When building mldonkey-3.1.1, the second compile error we get using llvm-gcc-4.2.1 or clang-3.1 from XCode-4.3.3 besides the error reported in issue 7727 is that, on OSX, sed doesn't not have a -o option to direct the output to a file.  I can fix this using > instead. 

This is the error we see (after applying the change from 7727)


$ make install
cpp -P src/utils/cdk/tar.mlcpp | sed -n '/^#pragma/!p' -o src/utils/cdk/tar.ml
cpp -P src/utils/lib/misc2.mlcpp | sed -n '/^#pragma/!p' -o src/utils/lib/misc2.ml
sed: -o: No such file or directory
sed: src/utils/lib/misc2.ml: No such file or directory
sed: -o: No such file or directory
sed: src/utils/cdk/tar.ml: No such file or directory
make: *** [src/utils/cdk/tar.ml] Error 1
make: *** Waiting for unfinished jobs....
make: *** [src/utils/lib/misc2.ml] Error 1



I've attched the patches we are applying to get mldonkey to compile that fix 7727 and the sed bug.

I've attached my config.log and make.log also to show the build when it errors.  Thanks for your help.

nibbles
[field #16]               Item Group: Compilation problem
[field #17]                   Status: None
[field #18]        Component Version: None
[field #19]         Operating System: Mac OS X 10.4
[field #20]          Reproducibility: None
[field #21]               Size (loc): None
[field #22]            Fixed Release: None
[field #23]          Planned Release: None
[field #24]                   Effort: 0.00
[field #28]                 Priority: 5 - Normal
[field #31]         Percent Complete: 0%
[field #33]                  Release: None
[field #34]                  Release: 3.1.1
[field #58]          Binaries Origin: CVS / Self compiled
[field #59]                 CPU type: x86_64
[field #60]                      CPU: None
[field #61]     Custom Select Box #4: None
[field #62]     Custom Select Box #5: None
[field #63]     Custom Select Box #6: None
[field #64]     Custom Select Box #7: None
[field #65]     Custom Select Box #8: None
[field #66]     Custom Select Box #9: None
[field #67]    Custom Select Box #10: None

spiralvoice <spiralvoice>
Group administrator
Sun 17 Jun 2012 01:51:18 AM UTC, comment #2: 

Oh that works perfectly with clang and llvm-gcc on Lion 10.7.4 from XCode-4.3.3.

I guess this was only a sed issue.  I will change the patch that Homebrew uses.

Thanks!

nibbles <github_2bits>
Fri 15 Jun 2012 07:02:47 PM UTC, comment #1: 

What happens if you use shell redirection > but leave $(CPP) -x c as is?
http://mldonkey.sourceforge.net/phpBB2/viewtopic.php?p=31986#31986

ygrek <ygrek>
Group Member
Sat 23 Jun 2012 11:25:12 AM UTC, original submission:  

Reporting this for Homebrew a package installer for Macs.

When building mldonkey-3.1.1, the second compile error we get using llvm-gcc-4.2.1 or clang-3.1 from XCode-4.3.3 besides the error reported in issue 7727 is that, on OSX, sed doesn't not have a -o option to direct the output to a file.  I can fix this using > instead. 

This is the error we see (after applying the change from 7727)


$ make install
cpp -P src/utils/cdk/tar.mlcpp | sed -n '/^#pragma/!p' -o src/utils/cdk/tar.ml
cpp -P src/utils/lib/misc2.mlcpp | sed -n '/^#pragma/!p' -o src/utils/lib/misc2.ml
sed: -o: No such file or directory
sed: src/utils/lib/misc2.ml: No such file or directory
sed: -o: No such file or directory
sed: src/utils/cdk/tar.ml: No such file or directory
make: *** [src/utils/cdk/tar.ml] Error 1
make: *** Waiting for unfinished jobs....
make: *** [src/utils/lib/misc2.ml] Error 1



I've attched the patches we are applying to get mldonkey to compile that fix 7727 and the sed bug.

I've attached my config.log and make.log also to show the build when it errors.  Thanks for your help.

nibbles

nibbles <github_2bits>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #26025:  config.log added by github_2bits (52KiB - application/octet-stream - Patches, config.log and make.log)
file #26026:  make.log added by github_2bits (11KiB - application/octet-stream - Patches, config.log and make.log)
file #26023:  Makefile.diff added by github_2bits (422B - application/octet-stream - Patches, config.log and make.log)
file #26024:  Makefile.in.diff added by github_2bits (442B - application/octet-stream - Patches, config.log and make.log)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by spiralvoice (Updated the item)
  • -email is unavailable- added by ygrek (Posted a comment)
  • -email is unavailable- added by github_2bits (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-06-24 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2012-06-23 spiralvoice Assigned toNone ygrek
    2012-06-23 spiralvoice Attached File- Added mldonkey.git-5ba13dd547e65c93845a6cff9653fc739bd28704.patch, #26090
    2012-06-23 spiralvoice Reassign itemmldonkey, a multi-networks file-sharing client, bug #36654 mldonkey, a multi-networks file-sharing client, patch #7798

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code