patchWeeChat - Patches: patch #7972, weechat's icon is not being...

 
 

patch #7972: weechat's icon is not being installed via cmake

Submitter:  None
Submitted:  Tue 12 Mar 2013 08:53:14 PM UTC
 
Category:  packaging Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  flashcode Originator Email:  -email is unavailable-
Open/Closed:  Closed IRC nick:  tomboy64
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Wed 10 Apr 2013 09:00:18 AM UTC, comment #2: 

Hi,

I already committed your patch, but with changes, and I removed the line with @ONLY (not needed).

Please look at my commit, and tell me if there is a problem for you:
http://git.savannah.gnu.org/gitweb/?p=weechat.git;a=commitdiff;h=4b4d80b;hp=cac2342

Sebastien Helleu <flashcode>
Project Administrator
Mon 08 Apr 2013 11:06:28 PM UTC, comment #1: 

my apologies; the provided patch contained an error which corrupts the installed icon with variable expansion. this version 2 replaces the @ONLY instruction with COPYONLY which should remedy this problem.

(file #27820)

Anonymous
Tue 12 Mar 2013 08:53:14 PM UTC, original submission:  

This patch makes cmake install the (already provided) icon for weechat.
Please review whether the icon path is correct/sane - it seems to be for my Gentoo Linux distro.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #27820:  weechat-icon.patch added by None (1KiB - text/x-patch - patch for CMakeLists.txt - version 2)
file #27599:  cmake_install_icon.patch added by None (1002B - text/x-patch - patch for CMakeLists.txt)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by flashcode (Updated the item)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-05-20 flashcode Open/ClosedOpen Closed
    2013-04-08 None Attached File- Added weechat-icon.patch, #27820
    2013-03-24 flashcode StatusNone Done
        Assigned toNone flashcode
    2013-03-12 None Attached File- Added cmake_install_icon.patch, #27599

    Back to the top


    Powered by Savane 3.9