lwIP - A Lightweight TCP/IP stack - Patches: patch #9699, the overflow check in tcp_recved...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9699: the overflow check in tcp_recved is not correct
Submitter: | Jonas Rabenstein <ghostav> | ||
Submitted: | Wed 10 Oct 2018 10:44:57 PM UTC | ||
Category: | TCP | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | None | Open/Closed: | Closed |
Planned Release: | None |
Mon 12 Nov 2018 08:03:22 PM UTC, comment #2: |
Simon Goldschmidt <goldsimon> |
Thu 11 Oct 2018 05:34:10 AM UTC, comment #1: Applied, thanks! |
Dirk Ziegelmeier <dziegel> |
Wed 10 Oct 2018 10:44:57 PM UTC, original submission:
A variable is overflowed if the result of the addition is smaller than its previous value. The current implementation in tcp_received does this wrong by simply comparing the result of the addition to 0. |
Jonas Rabenstein <ghostav> |
Attached Files
file #45179: 0001-tcp_recved-check-for-overflow-and-warn-about-too-big.patch added by ghostav (2KiB - text/x-patch)
Depends on the following items: None found
Items that depend on this one: None found
Carbon-Copy List
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 3 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-10-11 | dziegel | Status | None | Done | |
Open/Closed | Open | Closed | |||
2018-10-10 | ghostav | Attached File | - | Added 0001-tcp_recved-check-for-overflow-and-warn-about-too-big.patch, #45179 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Fixed in a more generic way. Using assertions here was not a good idea, unfortunately... :-(