patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9847, Fixes in IPv4 autoip

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9847: Fixes in IPv4 autoip

Submitter:  Sathish M <sathishm6>
Submitted:  Wed 28 Aug 2019 04:54:50 AM UTC
   
 
Category:  IPv4 Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Tue 10 Dec 2019 08:45:17 PM UTC, comment #2: 

After having a deeper look, one of your changes is fixed by patch #9861, the others are invalid.

Simon Goldschmidt <goldsimon>
Group administrator
Tue 10 Dec 2019 08:33:34 PM UTC, comment #1: 

In the master branch, autoip has significantly changed as it has been split into acd.c (which now can do ACD for non-AutoIP addresses, too) and autoip.c.

Being like that, this patch doesn't apply any more.

However, since patch #9861 tries to make ACD conformant for Bonjour tests, this might be fixed as well?

Simon Goldschmidt <goldsimon>
Group administrator
Wed 28 Aug 2019 04:54:50 AM UTC, original submission:  

This patch fixes following issues in autoip.
  1) Corrected the condition for limiting the probe interval to match RFC 3927, Section 2.2.1.
  2) Added fixes in autoip_stop() to avoid memory leak during autoip_start() -> autoip_stop() sequence.

Additional Details:
  1. Fixed bug in max conflict rate limiting.
      - According to RFC section RFC 3927 Section 2.2.1 conflict probe interval
        should be increased to RATE_LIMIT_INTERVAL (60 seconds), after conflict count reaches
        MAX_CONFLICTS (i.e., 10) counts.
      - The initial value of 'autoip->tried_llipaddr' is 0. Hence the probe
        interval (i.e., autoip->ttw) should be increased to RATE_LIMIT_INTERVAL (60 secs)
        when the condition becomes 'autoip->tried_llipaddr >= MAX_CONFLICTS'

  2. Added code to free 'autoip' client in autoip_stop() API.
      - 'autoip' client is allocated in autoip_start() API, this client is not
        freed during autoip_stop() or in any other part of the code.
      - Updated autoip_stop() API to release the memory allocated for 'autoip' client during start.

Tag used as a base revision to apply the fix: : STABLE-2_1_2_RELEASE

Sathish M <sathishm6>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #47402:  autoip_fix.patch added by sathishm6 (3KiB - application/octet-stream - Patch file with autoip fixes)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by sathishm6
  • -email is unavailable- added by sathishm6 (Submitted the item)
  • -email is unavailable- added by sathishm6 (Please add other reviewers as needed. Thanks.)
  • -email is unavailable- added by sathishm6 (Please add other reviewers as needed. Thanks.)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-12-10 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2019-08-29 sathishm6 Carbon-Copy- Added axellin
    2019-08-28 sathishm6 Attached File- Added autoip_fix.patch, #47402
        Carbon-Copy- Added goldsimon
        Carbon-Copy- Added dziegel

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code