lwIP - A Lightweight TCP/IP stack - Patches: patch #7885, modification of api modules to...
You are not allowed to post comments on this tracker with your current authentication level.
patch #7885: modification of api modules to support FreeRTOS-MPU (NO_SYS = 0)
Submitter: | Artem Pisarenko <jblackarty> | ||
Submitted: | Wed 14 Nov 2012 05:08:13 AM UTC | ||
Category: | sockets/netconn | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Fri 21 Feb 2014 08:05:40 AM UTC, comment #8: |
Simon Goldschmidt <goldsimon> |
Fri 21 Feb 2014 05:53:30 AM UTC, comment #7: I'm glad to see my contribution accepted.
Firstly, condition will never be true because of LWIP_ERROR() check above. Secondly, if it even would be, 'addr' will point to constant variable, followed with
|
Artem Pisarenko <jblackarty> |
Thu 20 Feb 2014 06:51:19 PM UTC, comment #6: Done, thanks for the patch.
|
Simon Goldschmidt <goldsimon> |
Sat 24 Nov 2012 09:41:22 AM UTC, comment #5: Actually I was able to avoid mess of #ifdef-else-endif insertions. Instead, replacements ans small additions was made with macros which are defined conditionally (in most places). The resulting code turned out to be not so bloated as expected. |
Artem Pisarenko <jblackarty> |
Fri 23 Nov 2012 05:27:17 PM UTC, comment #4: I haven't had time to review this patch yet, but here are my comments:
|
Ivan Delamer <idelamer> |
Fri 23 Nov 2012 01:34:57 PM UTC, comment #3: I made it configurable. See new patch attached (draft3).
|
Artem Pisarenko <jblackarty> |
Fri 23 Nov 2012 03:52:42 AM UTC, comment #2: But how exactly you propose to make it configurable ? Wrap all changes with preprocessor directives depending on option in lwipopts.h ? I'll try that but in my opinion it will make code more difficult to maintain and you might reject it. This will make my work meaningless. |
Artem Pisarenko <jblackarty> |
Thu 22 Nov 2012 05:18:31 PM UTC, comment #1: Thanks for the patch. It does make sense if you want MPU support enabled.
|
Simon Goldschmidt <goldsimon> |
Wed 14 Nov 2012 05:08:13 AM UTC, original submission:
The patch makes lwip support system architectures (ports) based on FreeRTOS-MPU (with memory protection unit) where tcpip thread must be run in user mode. (Modification support lwip usage in all cases but I didn't considered PPP. Maybe PPP module doesn't require modifications ever and will work.)
|
Artem Pisarenko <jblackarty> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-02-20 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2013-01-15 | goldsimon | Category | None | sockets/netconn | |
2012-11-23 | jblackarty | Attached File | - | Added lwip_mpu_redesign__draft3.patch, #26962 | |
2012-11-14 | jblackarty | Attached File | - | Added lwip_mpu_redesign__draft2.patch, #26912 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Good catch, I hope I fixed it now.