lwIP - A Lightweight TCP/IP stack - Patches: patch #9262, Support for 32bit errno codes
You are not allowed to post comments on this tracker with your current authentication level.
patch #9262: Support for 32bit errno codes
Submitter: | Joan Lledó <jllledo> | ||
Submitted: | Fri 17 Feb 2017 09:52:22 AM UTC | ||
Category: | sockets/netconn | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | goldsimon | Open/Closed: | Closed |
Planned Release: | None |
Jump to the original submission
Mon 20 Feb 2017 08:02:45 PM UTC, comment #7: |
Simon Goldschmidt <goldsimon> |
Mon 20 Feb 2017 04:50:21 PM UTC, comment #6: Your last change seems a good idea, why have you reverted it? Thanks for your time. |
Joan Lledó <jllledo> |
Mon 20 Feb 2017 12:30:56 PM UTC, comment #5: And reverted the last mentioned change: Let's stay with the standard and accept the 4-bytes-per-socket memory increase... |
Simon Goldschmidt <goldsimon> |
Mon 20 Feb 2017 11:54:42 AM UTC, comment #4: I've changed it again so that the default type is now 's8_t' for LWIP_PROVIDE_ERRNO and 'int' for the external errno.h case (which is what you're using). |
Simon Goldschmidt <goldsimon> |
Mon 20 Feb 2017 11:44:41 AM UTC, comment #3: Still needed more fixes, but this should be done now. Thanks for the patch. |
Simon Goldschmidt <goldsimon> |
Fri 17 Feb 2017 03:01:42 PM UTC, comment #2: Sorry for the lack of description.
|
Joan Lledó <jllledo> |
Fri 17 Feb 2017 11:18:36 AM UTC, comment #1: It would have helped to include a description in the original submission.
|
Simon Goldschmidt <goldsimon> |
Fri 17 Feb 2017 09:52:22 AM UTC, original submission:
|
Joan Lledó <jllledo> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 5 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-02-20 | goldsimon | Status | None | Done | |
Assigned to | None | goldsimon | |||
Open/Closed | Open | Closed | |||
2017-02-17 | jllledo | Attached File | - | Added 0001-Support-for-32bit-errno-codes.patch, #39775 | |
2017-02-17 | jllledo | Attached File | - | Added 0001-Support-for-32bit-errno-codes.patch, #39771 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Because we already have too many defines that keep breaking the source code when changes are made (as your patch broke the !CORE_LOCKING case). And since sockets are rather used for bigger systems, I felt the 4 bytes per socket aren't worth it. Especially when seeing that the standard defines the error codes as int...