lwIP - A Lightweight TCP/IP stack - Patches: patch #5959, Implement SO_RCVTIMEO for accept...
You are not allowed to post comments on this tracker with your current authentication level.
patch #5959: Implement SO_RCVTIMEO for accept and recv (on TCP netconn)
Submitter: | Frédéric Bernon <fbernon> | ||
Submitted: | Wed 23 May 2007 10:32:20 AM UTC | ||
Category: | None | Priority: | 3 - Low |
Status: | Done | Privacy: | Public |
Assigned to: | fbernon | Open/Closed: | Closed |
Planned Release: | None |
Thu 24 May 2007 03:20:44 PM UTC, comment #4: |
Frédéric Bernon <fbernon> |
Thu 24 May 2007 03:15:44 PM UTC, comment #3: Since you asked for a comment.... I don't think the code is made sufficiently more complex that this "simpler" is worth the test and set. It looks neater, but the version without the macro is still easy to understand and maintain. In fact, since someone would have to look up what macro does, I'm not sure it would save the complexity anyway.
|
Jonathan Larmour <jifl> |
Wed 23 May 2007 07:24:56 PM UTC, comment #2: Ok, I check in. Just a tips about the fact to call or not the conn->callback with NETCONN_EVT_RCVMINUS, I'm not 100% sure of the thing to do, but I have try to respect the current instruction flow, but tell me.
|
Frédéric Bernon <fbernon> |
Wed 23 May 2007 01:40:19 PM UTC, comment #1: Looks fine to me. |
Jonathan Larmour <jifl> |
Wed 23 May 2007 10:32:20 AM UTC, original submission:
It's a very simple patch I propose :
|
Frédéric Bernon <fbernon> |
No files currently attached
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 2 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-05-24 | fbernon | Status | None | Done | |
Open/Closed | Open | Closed |
Powered by Savane 3.13-d3ae.
Corresponding source code
So, if I understand, like it's check in, it's good for you?
Ok, so, I close that... (reopen if I'm wrong...)