patchBos Wars - Patches: patch #7197, Add a hot key for the "Show...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #7197: Add a hot key for the "Show terrain attributes" check box in the editor menu

Submitter:  Kalle Olavi Niemitalo <kon>
Submitted:  Mon 17 May 2010 11:37:25 PM UTC
   
 
Open/Closed:  Open Status:  None
Assigned to:  None

Sat 22 May 2010 09:08:10 AM UTC, comment #1: 

I added the check box itself in r9864 but it doesn't have a hot key yet.  New patches attached.



(file #20579, file #20580, file #20581)

Kalle Olavi Niemitalo <kon>
Group Member
Mon 17 May 2010 11:37:25 PM UTC, original submission:  

A series of three patches for trunk r9859.  The purpose being to make the terrain-flags-as-colors feature of the map editor easier to discover.

I'm not pushing this straight to svn because I'm not sure command keys should be localized like this, especially with bug #29094.  However, the alternatives aren't nice either.  If we hardcode 't' as the command key and advise translators to use 't' also as the hot key of the check box, then the translators may have to change the hot key of "Exit to menu" in order to prevent a clash.  Or, if we don't advise translators that way, then the 't' command key will be visible nowhere, unless we also add a help screen in the editor.

Kalle Olavi Niemitalo <kon>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #20580:  0002-Add-UI-HotKeyOfCaption-for-Lua.patch added by kon (4KiB - text/x-patch - PATCHv2)
file #20559:  0001-Support-implicit-hot-keys-for-check-boxes.patch added by kon (15KiB - text/x-patch - patch v1 in three parts)
file #20560:  0002-Add-UI-HotKeyOfCaption-for-Lua.patch added by kon (4KiB - text/x-patch - patch v1 in three parts)
file #20561:  0003-Add-Show-terrain-attributes-check-box-in-editor-menu.patch added by kon (13KiB - text/x-patch - patch v1 in three parts)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by kon (Submitted the item)
  •  

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2010-05-22 kon Attached File- Added 0001-Support-implicit-hot-keys-for-check-boxes.patch, #20579
        Attached File- Added 0002-Add-UI-HotKeyOfCaption-for-Lua.patch, #20580
        Attached File- Added 0003-Add-hot-key-for-Show-terrain-attributes-in-editor-me.patch, #20581
        SummaryAdd &quot;Show terrain attributes&quot; check box in editor menu Add a hot key for the "Show terrain attributes" check box in the editor menu
    2010-05-17 kon Attached File- Added 0001-Support-implicit-hot-keys-for-check-boxes.patch, #20559
        Attached File- Added 0002-Add-UI-HotKeyOfCaption-for-Lua.patch, #20560
        Attached File- Added 0003-Add-Show-terrain-attributes-check-box-in-editor-menu.patch, #20561

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code