patchlwIP - A Lightweight TCP/IP stack - Patches: patch #9807, New function tcpip_callback_wait()

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9807: New function tcpip_callback_wait()

Submitter:  Joan Lledó <jllledo>
Submitted:  Sun 19 May 2019 09:29:52 AM UTC
   
 
Category:  sockets/netconn Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  goldsimon Open/Closed:  Closed
Planned Release:  None

Sat 13 Jul 2019 06:53:26 PM UTC, comment #1: 

Pushed, thanks for the patch.

Simon Goldschmidt <goldsimon>
Group administrator
Sun 19 May 2019 09:29:52 AM UTC, original submission:  

This comes from [1].

I wrote a patch which adds a new function to call a callback inside the tcpip thread ans block the calling thread until the callback finishes. While writing it I came into some questions:

1.- Do you think it's useful to add support for LWIP_NETCONN_SEM_PER_THREAD?

2.- Should I use TCPIP_MSG_VAR_ALLOC() and friends instead of declaring msg directly? I understand what these macros do, but I don't know what's the problem they solve. So i don't know whether this new function should use them.

3.- Should I allocate msg in dynamic memory instead of declaring it locally? Since the calling thread is blocked, msg will remain in the scope when the tcpip thread tries to read it.

4.- If I allocate msg, then should the tcpip thread free it?

----------------
[1] http://lists.nongnu.org/archive/html/lwip-devel/2019-05/msg00020.html

Joan Lledó <jllledo>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by goldsimon (Posted a comment)
  • -email is unavailable- added by jllledo (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-07-13 goldsimon StatusNone Done
        Assigned toNone goldsimon
        Open/ClosedOpen Closed
    2019-05-19 jllledo Attached File- Added 0001-New-function-tcpip_callback_wait.patch, #46926

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code