maindavfs2 - Support: sr #108104, davfs2 fix DESTDIR support

 
 

sr #108104: davfs2 fix DESTDIR support

Submitter:  Jeremy Olexa <jolexa>
Submitted:  Wed 08 Aug 2012 06:27:20 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  _71007
Open/Closed:  Closed Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 20 Aug 2012 07:10:39 PM UTC, comment #3: 

After taking some more time to think about it and after remembering the syntax of the ln command I can't help but recognizing that you are right.

I fixed it in CVS (MAIN branch and the rel-1-4-6 branch).

Thanks for insisting
Werner

- <_71007>
Mon 20 Aug 2012 01:12:29 PM UTC, comment #2: 

Hello, Thanks for the follow up, Werner.

You can consider the next step after "make DESTDIR=/foo install" to be "cp DESTDIR /" if you have the proper access (root). With that in mind, you can see that the symlinks are wrong which is what this patch fixes.

Anyway, it isn't distro specific but rather a general bug. I found two other distros that "fix" symlinks in my cursory search.

https://projects.archlinux.org/svntogit/packages.git/tree/trunk/PKGBUILD?h=packages/davfs2

http://pkgs.fedoraproject.org/cgit/davfs2.git/commit/?id=08508757de456429b5519bb8481aefcbdcb74288

I hope that you reconsider this bug, thanks.

Jeremy Olexa <jolexa>
Sun 19 Aug 2012 08:00:32 PM UTC, comment #1: 

I must confess that I'm confused about these Gentoo bug reports.

As far as I understand DESTDIR is used to build a package within DESTDIR and without the need of root priveleges. The build process must only create files in DESTDIR and not touch any system files, links or directories. In short: the build process must treat DESTDIR as root of the file system, without exception.

of course there will be a problem with testing because the system's mount command does not know about DESTDIR. I don't know a way around these problems (maybe chroot for testing?).

But changing the build process as you propose would probably earn me a lot of bug reports from other distributions.

Cheers
Werner

- <_71007>
Wed 08 Aug 2012 06:27:20 PM UTC, original submission:  
Jeremy Olexa <jolexa>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by _71007 (Posted a comment)
  • -email is unavailable- added by jolexa (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2014-04-22 _71007 Open/ClosedOpen Closed
    2012-08-20 _71007 StatusWont Do Done
    2012-08-19 _71007 StatusNone Wont Do
        Assigned toNone _71007

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code