helpSCADA plastic rolling machine - Support: sr #109551, Make sure this group meets...

 
 

sr #109551: Make sure this group meets Savannah hosting requirements

Submitted by:  Ineiev <ineiev>
Submitted on:  Tue 04 Sep 2018 12:52:17 PM UTC  
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Operating System:  None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Thu 20 Sep 2018 07:38:23 AM UTC, comment #18:

I forgot to push my commit.

It's done now, well the alarms CSV is totally optional, and configurable (for all this it's in a CSV not in source code)

I think it's enough with the instructions given in README, and the texted example provided. As README is already licensed.

In fact I think is better as I provide documentation about setting your own alarms and messages.

cheers

Joaquín Cuéllar <gentooza>
Project Administrator
Wed 19 Sep 2018 05:29:33 PM UTC, comment #17:

> well I don't understand your proposal about preprocessing.


It means that you first automatically remove the comments, and then give it to the program.

> what I've done is capture it as a photo example in images, and talked about it in README. Finally I removed also the polemic file.


I can't see that change in your repository; anyway, I'm afraid, that won't do.

If you put a graphical file without its source (in that case, the original CSV file), you make your package unredistributable, because the GPL requires that the redistributors provide the full corresponding source code, and they would have no source for that file.

Ineiev <ineiev>
Tue 18 Sep 2018 07:38:27 AM UTC, comment #16:

Hi!

well I don't understand your proposal about preprocessing.

what I've done is capture it as a photo example in images, and talked about it in README. Finally I removed also the polemic file.

is it ok?
cheers

Joaquín Cuéllar <gentooza>
Project Administrator
Mon 17 Sep 2018 11:10:43 AM UTC, comment #15:

If that program can't handle comments, you can preprocess the file.

Ineiev <ineiev>
Sat 15 Sep 2018 06:43:30 PM UTC, comment #14:

But I can't insert a license header in the CSV file, if I do that program fails to take the raw data in there. :-/

Joaquín Cuéllar <gentooza>
Project Administrator
Sat 15 Sep 2018 05:38:56 PM UTC, comment #13:

Yes, it's enough for those files; however, some files still lack notices, for example, alarm.csv. Please check them all and make sure that valid notices are present.

Ineiev <ineiev>
Thu 13 Sep 2018 08:19:26 AM UTC, comment #12:

OK, I added the copyright notice to modbus_client.cpp, and copy whole license header in the QT .pro file of modbus_client.

is it enough?

thanks, and cheers
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Wed 12 Sep 2018 05:36:09 PM UTC, comment #11:

> Ok, so I think I've finished


Thank you!

> I'm not too sure about the modbus_client folder, it's an external application but with custom configuration files.


It doesn't matter whether it is external application or a subroutine, it doesn't matter who wrote it; since you put these files in your tarball, you should make sure they all have valid copyright and license notices.

Ineiev <ineiev>
Tue 11 Sep 2018 09:00:19 AM UTC, comment #10:

Ok, so I think I've finished

I'm not too sure about the modbus_client folder, it's an external application but with custom configuration files.

I added a readme there, I don't know if it's enough.

thanks for your time,
cheers,
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Tue 11 Sep 2018 06:50:38 AM UTC, comment #9:

Yes, these two files are fine.

Ineiev <ineiev>
Mon 10 Sep 2018 06:02:45 AM UTC, comment #8:

Hi,

I'm really sorry about the late response.

Ok, So I've set only the main copyright holder, is mask5.cpp fine now?

COPYING file fixed also, by the way.

thanks, and cheers
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Fri 07 Sep 2018 01:27:12 PM UTC, comment #7:

It's desirable to have copyright and license info embedded in files, because it's easy for developers of other packages to copy source files and forget about the rest; in such cases if the notices are written somewhere else, they'll be lost.

If there are multiple copyright holders, you should provide a copyright notice for the main copyright holder and (optionally) copyright notices for other people who have contributed large amounts.

Please check GNU documentation on copyright notices, it explains the matter much better than I can.

Ineiev <ineiev>
Fri 07 Sep 2018 11:19:28 AM UTC, comment #6:

I guessed that.

but what Can I do if there are several copyright holders?

I thought there was some kind of mechanism of "by the authors, see file authors"

isn't it?

cheers,
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Wed 05 Sep 2018 01:52:50 PM UTC, comment #5:

The license notice is fine (I'd just recommend rewrapping the long line), but the copyright line isn't: it says "copyright by its authors" which is almost a tautology. It should be more specific.

Ineiev <ineiev>
Wed 05 Sep 2018 10:35:32 AM UTC, comment #4:

Hi,

I've modified mask5.cpp with the license and copyright header I think is correct.

Please could you confirm it's ok, or give some hints if it's already wrong?

Once finished I'll insert the same in other source files.

cheers,
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Tue 04 Sep 2018 07:11:47 PM UTC, comment #3:

same as in [sr #109552], I'll do the faster I can.

I'll make the progress public in both tasks as I start finishing points.

cheers,
Joaquín

Joaquín Cuéllar <gentooza>
Project Administrator
Tue 04 Sep 2018 01:45:23 PM UTC, comment #2:

> The only point I not agree is about qt4, if I'm not mistake, it's also licensed under LGPLv2.1 and LGPLV3


I think you are right.

When are you planning to fix the rest?

Ineiev <ineiev>
Tue 04 Sep 2018 01:16:23 PM UTC, comment #1:

Hi!

Of course!
work in progress.

The only point I not agree is about qt4, if I'm not mistake, it's also licensed under LGPLv2.1 and LGPLV3, so I think there is no problem linking it in a GPLV3+ application. (https://www.gnu.org/licenses/gpl-faq.html#AllCompatibility)

Is it ok?

cheers
Joa

Joaquín Cuéllar <gentooza>
Project Administrator
Tue 04 Sep 2018 12:52:17 PM UTC, original submission:

This package doesn't comply with some Savannah policies:

  • Some files like README and mask7.cpp lack copyright and license notices.
  • Copyright notices in files like mask5.cpp aren't really valid, and license notices say it's GPLv3-only. Savannah policies require that software must be GPLv3+-compliant.
  • The package depends on Qt4, it's GPLv3-only; in order to make the package effectively GPLv3+, dependencies like that should be eliminated.
  • The COPYING file is a modified version of the canonical GPLv3 text; developers should use https://www.gnu.org/licenses/gpl-3.0.txt.

Could you please fix that?

Ineiev <ineiev>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gentooza (Posted a comment)
  • -email is unavailable- added by ineiev (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    No changes have been made to this item

    Back to the top


    Powered by Savane 3.3