mainManeage - Support: sr #110651, Compiler flag necessary to build...

 
 

sr #110651: Compiler flag necessary to build the `file` program on Centos 7

Submitter:  None
Submitted:  Fri 13 May 2022 10:57:14 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  2 - Minor Status:  Done
Privacy:  Public Assigned to:  makhlaghi
Originator Email:  -email is unavailable- Open/Closed:  Closed
Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 15 May 2022 09:20:31 PM UTC, comment #1: 

Thanks a lot Manuel, (after some minor modifications, your commit has been merged into the core Maneage branch as Commit 58eb63c1. So I am closing this issue.

Here is a list of the modifications:

  • The commit title ended with a '.'. Titles generally don't end with a full-stop; you can have a look at the Table of contents of any book for example ;-). Maneage follows the same commit guidelines as Gnuastro (GNU Astronomy Utilities).
  • To help get a feeling of which part of Maneage the commit belongs to, we try to put a summary of it in the first word before a colon, you can see the full list of recent commits here as an example: https://git.maneage.org/project.git/log
  • In the first paragraph, the version of GCC was missing; so I added it based on your report in the Matrix-prototol room.
  • Following the commit guidelines, the second (solution) paragraph of the commit message should start with "With this commit, ".
  • I expanded the second paragraph a little with some extra explanation ;-).
  • The slanted-quotes (`) are used in markdown to identify code, but in plain-text, they are not rendered and their usage is un-common within ASCII, human-readable text. So we simply use a single quote (') to identify parts of the text that are code.
  • Finally, in the actual changed line, I added a '$$CFLAGS' to keep any existing values the user may have given to this environment variable (when building the programs in 'basic.mk'; we still rely on the host compiler and the user's environment).


Congratulations on the first commit in Maneage, and thanks a lot for helping make Maneage more stable for everyone :-).

Mohammad Akhlaghi <makhlaghi>
Group administrator
Fri 13 May 2022 10:57:14 PM UTC, original submission:  

Dear maintainers

I uploaded a fork of Maneage and a branch with the fix discussed in the Matrix chat room at
https://github.com/masolimano/maneage/tree/fix-file-build

Thanks for all your support.

Best,
Manuel

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by makhlaghi (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-05-15 makhlaghi SummaryPull request: Added compiler flag necessary to build the `file` program on Centos 7 Compiler flag necessary to build the `file` program on Centos 7
    2022-05-15 makhlaghi StatusNone Done
        Assigned toNone makhlaghi
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code