mainSavannah Administration - Support: sr #110984, [php] Disabling php exec function...

 
 

sr #110984: [php] Disabling php exec function breaks multiple things

Submitter:  Jing Luo <jing>
Submitted:  Wed 20 Dec 2023 01:56:52 PM UTC
   
 
Category:  Savane Priority:  5 - Normal
Severity:  5 - Blocker Status:  Done
Privacy:  Public Assigned to:  ineiev
Operating System:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 20 Dec 2023 05:23:01 PM UTC, comment #1: 

Thank you, fixed.

Ineiev <ineiev>
Site Administrator
Wed 20 Dec 2023 01:56:52 PM UTC, original submission:  

A recent commit of savane introduced php.ini, which has a line "disable_functions = exec,passthru,popen,shell_exec,system". apache.conf also has a line doing the same thing, but that's another story.

This doesn't work for me: exec is being used by these files:
./frontend/php/include/utils.php:  exec ("rm -fr $dir");
./frontend/php/include/account.php:  $pwqgen = exec ("pwqgen");
./frontend/php/include/vcs/git.php:  exec ("grep -A 3 '^repo\.url=$group_name\(/\|\.git$\)' $sys_etc_dir/cgitrepos", $output);

It breaks login, register (new user), get list from cgit, and gpg.

Because in apache.conf, we already have SetHandler default-handler, I don't think disabling exec is necessary.

Jing Luo <jing>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by jing (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-20 ineiev StatusNone Done
        Assigned toNone ineiev
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-04b1.
    Corresponding source code