mainSavannah Administration - Support: sr #110994, savane.conf.php: missing...

 
 

sr #110994: savane.conf.php: missing $sys_vcs_dir

Submitter:  Jing Luo <jing>
Submitted:  Tue 26 Dec 2023 01:43:38 PM UTC
   
 
Category:  Savane Priority:  5 - Normal
Severity:  3 - Normal Status:  Postponed
Privacy:  Public Assigned to:  ineiev
Operating System:  None Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 28 Dec 2023 07:00:22 AM UTC, comment #5: 


comment #4:

>
> I mentioned that $sys_vcs_dir is missing in savane.conf.php.in because there is no documentation/instruction anywhere to tell a newbie to set it up.


Correct, the documentation is missing.

> The purpose of savane.conf.php is to tell a user what need to be configured for savane to work, is it not?


Not exactly; the purpose of savane.conf.php is to tell frontend what settings to use.

Ineiev <ineiev>
Site Administrator
Thu 28 Dec 2023 06:15:46 AM UTC, comment #4: 


comment #3:

> comment #2:
> > It's still blank even after the path is populated with git repos generated by sv_groups and GitMakeArea.
>
> To be on the same page: the page works substantially when both the path is populated and the variable is set.


OK, let me clarify my point.

I mentioned that $sys_vcs_dir is missing in savane.conf.php.in because there is no documentation/instruction anywhere to tell a newbie to set it up.

The purpose of savane.conf.php is to tell a user what need to be configured for savane to work, is it not?

Jing Luo <jing>
Group Member
Thu 28 Dec 2023 04:36:18 AM UTC, comment #3: 

comment #2:

> It's still blank even after the path is populated with git repos generated by sv_groups and GitMakeArea.


To be on the same page: the page works substantially when both the path is populated and the variable is set.

> On other vcs, the url is contructed using $project->getUnixName().


Yes; for other VCS, the code doesn't check the presence of the repos.

Both approaches work when the tree of the repositories are in place and the variables are set correctly; when anything is missing, it doesn't matter if the page is empty or not. the point is, nothing should be missing.

Ineiev <ineiev>
Site Administrator
Thu 28 Dec 2023 12:59:28 AM UTC, comment #2: 


comment #1:

> The list of repositories will be blank until the specified path is populated with Git repositories; it makes little sense to point at a place that doesn't exist.


It's still blank even after the path is populated with git repos generated by sv_groups and GitMakeArea.

Unlike cvs, bzr, or svn, in site-specific, the "Use Git" page contructs git repo url using a variable $repo_list, which is defined in a function in include/vcs.php. $repo_list will be empty if $sys_vcs_dir is not defined. From what I can tell in the git log, it seems that this way of supporting multiple git repos for one group was introduced around 2017. On other vcs, the url is contructed using $project->getUnixName().

Jing Luo <jing>
Group Member
Wed 27 Dec 2023 03:43:34 PM UTC, comment #1: 

The list of repositories will be blank until the specified path is populated with Git repositories; it makes little sense to point at a place that doesn't exist.

Ineiev <ineiev>
Site Administrator
Tue 26 Dec 2023 01:43:38 PM UTC, original submission:  

Hi,

savane.conf.php is missing a variable which will cause "Use Git: Getting a Copy of the Git Repository" to be blank.

$sys_vcs_dir = [
  "git" => [
    "dir" => "/srv/git",
    "clone-path" => "/srv/git",
  ],
];

Also, these two should probably be written to savane.conf.php:

$sys_savane_url = '//' . $sys_https_host . '/projects/administration';
$sys_savane_cgit = '//' . $sys_https_host . '/cgit/administration.git';

Jing Luo <jing>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by ineiev (Posted a comment)
  • -email is unavailable- added by jing (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-12-27 ineiev Assigned toNone ineiev
    2023-12-27 ineiev StatusNone Postponed

    Back to the top

    Powered by Savane 3.13-c373.
    Corresponding source code