bugGluster - Bugs: bug #17288, argp support for all tools

 
 

bug #17288: argp support for all tools

Submitter:  Anand Avati <avati>
Submitted:  Thu 03 Aug 2006 03:22:06 PM UTC
   
 
Category:  GlusterFS Severity:  5 - Blocker
Priority:  7 - High Item Group:  Improper behaviour
Status:  Fixed Privacy:  Public
Assigned to:  gowda Originator Name:  *
Open/Closed:  Closed Release: 
Operating System:  GNU/Linux Reproducibility:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 07 Aug 2006 10:32:05 AM UTC, comment #3: 


the fix is not complete. argc calculation to fuse_main has to be calculated. the previous sizeof() will not work for calculating argc now since argv is not a fixed array, but dynamic.

below is the line which will fail --

glusterfs-fops.c:glusterfs_mount() - return fuse_main ((sizeof (argv) / sizeof (char *)) - 1, argv, &glusterfs_fops);


Anand Avati <avati>
Group Member
Sun 06 Aug 2006 10:44:22 PM UTC, comment #2: 

default options for glusterfs client must be given on command line only. Earlier hard-coding of mount options in glusterfs_mount have been removed.

also added new file glusterfs-ops.h to accomodate for a structure definition

Basavanagowda Kanur <gowda>
Group Member
Thu 03 Aug 2006 09:06:12 PM UTC, comment #1: 

glusterfs-fuse should propogate appropriate -o args to fuse_main()

Anand Avati <avati>
Group Member
Thu 03 Aug 2006 03:22:06 PM UTC, original submission:  

argp should be used in -

1. glusterfs-fuse
2. glusterfsd
3. glusterfs-shell

Anand Avati <avati>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 8 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-08-07 gowda StatusIn Progress Fixed
    Open/ClosedOpen Closed
2006-08-07 avati StatusFixed In Progress
2006-08-06 gowda StatusIn Progress Fixed
2006-08-04 gowda StatusNone In Progress
2006-08-03 avati Severity1 - Wish 5 - Blocker
    Priority5 - Normal 7 - High
2006-08-03 avati Assigned toNone gowda

Back to the top

Powered by Savane 3.13-d3ae.
Corresponding source code