patchThe nmh Mail Handling System - Patches: patch #1155, Speed up flist by skipping stat on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #1155: Speed up flist by skipping stat on files with #'s as names

Submitter:  None
Submitted:  Fri 21 Feb 2003 06:23:59 PM UTC
   
 
Category:  None Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  opk Originator Email:  -email is unavailable-
Open/Closed:  Closed

Wed 02 Nov 2005 05:47:13 PM UTC, comment #2: 

Have applied my updated patch to CVS.

Oliver Kiddle <opk>
Group Member
Fri 14 Oct 2005 04:38:55 PM UTC, comment #1: 

Testing this myself, I don't get quite such a speed improvement. The directory is probably cached causing the stat to be quicker. Changing the regex code to a simple loop, I was able to drop the time it takes to 75% relative to the code with your patch. It only needs to test that dp->d_name contains only digits. I've attached my patch. Would be good if you can test this patch.

Oliver Kiddle <opk>
Group Member
Fri 21 Feb 2003 06:23:59 PM UTC, original submission:  

Sent this patch to nmh-workders a while ago and not sure if it ever went through as I didn't see it posted there.  (Yes, I submitted the patch I'm commenting on.)  Figured if this is the repository for all things nmh, it belonged here.

This simple little twitch sped up flist considerably.  On my mail folders (which have a few thousand messages in them) it went from:

      138.45 real         0.43 user         8.13 sys

to

        5.46 real         0.65 user         0.44 sys

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #7990:  faster-flists.patch added by opk (820B - application/octet-stream - similar patch but without the use of a regex)
file #5303:  patch_item_1155.patch added by None (2KiB - text/plain - patch item 1155)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 5 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-11-02 opk StatusIn Progress Done
    Open/ClosedOpen Closed
2005-10-14 opk Assigned toNone opk
    Attached File- Added faster-flists.patch, #5326
2005-10-14 opk StatusNone In Progress

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code