Z80 assembler - Patches: patch #3406, Critical patch: address counter...
You are not allowed to post comments on this tracker with your current authentication level.
patch #3406: Critical patch: address counter corruption
Submitter: | H. Peter Anvin <hpanvin> | ||
Submitted: | Fri 01 Oct 2004 06:40:46 AM UTC | ||
Category: | None | Priority: | 9 - Immediate |
Status: | Done | Privacy: | Public |
Assigned to: | shevek | Open/Closed: | Closed |
Attached Files
Depends on the following items: None found
Items that depend on this one: None found
CC list is empty
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 4 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2004-10-01 | shevek | Status | None | Done | |
Assigned to | None | shevek | |||
Open/Closed | Open | Closed | |||
2004-10-01 | hpanvin | Attached File | - | Added jr.diff, #3720 |
Powered by Savane 3.13-4b48.
Corresponding source code
This patch addresses (so to speak) a missing addr++; which causes the address counter to be corrupted, resulting in completely garbled relocations from that point on.
After fixing the code there was a 1:1 correspondence between addr++; and write_one_byte() so I moved the addr++; into write_one_byte().
This also fixes bogus warnings about relative jumps being too far when using large ORGs.
This is a critical bug fix. I would appreciate it if you could make a release with this patch in it.