bugThe FreeType Project - Bugs: bug #58673, Freetype with CMake 3.17 and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #58673: Freetype with CMake 3.17 and higher versions generating warning

Submitter:  None
Submitted:  Mon 29 Jun 2020 11:31:27 AM UTC
   
 
Severity:  3 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open
Planned Release:  None

Mon 29 Jun 2020 11:31:27 AM UTC, original submission:  

As mentioned in https://www.mail-archive.com/freetype@nongnu.org/msg05488.html running CMake 3.17 and higher on older or the newest version of the library generates warnings

In the CMakeLists.txt line 216 and 218 make a find_package call with 'HarfBuzz' as argument but if you look at line 68 in FindHarfBuzz.cmake the argument is 'harfbuzz'. This upper/lowercase mismatch generates one of the warnings so I simply changed it to 'HarfBuzz' in FindHarfBuzz.cmake to solve the first warning.

On line 35 in FindHarfBuzz.cmake FindPkgConfig is included which generates the same warning. I changed this to:

find_package(PkgConfig QUIET)

As described in the following page the QUIET option disables informational messages
https://cmake.org/cmake/help/latest/command/find_package.html

On line 36 the pkg_check_modules is called with QUIET so it should be fine to use QUIET when trying to find the package as well. Not sure if this is necessarily the best solutions but it works.

Note that those changes are also made for FindBrotliDec.cmake as it generates the same warnings (i.e. include(FindPkgConfig) and upper/lowercase mismatch)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #49408:  FindHarfBuzz.cmake added by None (3KiB - application/octet-stream)
file #49409:  FindBrotliDec.cmake added by None (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2020-07-02 None Attached File- Added FindHarfBuzz.cmake, #49408
    Attached File- Added FindBrotliDec.cmake, #49409

Back to the top

Powered by Savane 3.13-f8d8.
Corresponding source code