bugMibble MIB Parser - Bugs: bug #16418, The...

 
 

bug #16418: The ObjectIdentifierValue.toString() method performance needs to be increased

Submitter:  Per Cederberg <cederberg>
Submitted:  Sun 23 Apr 2006 10:10:32 AM UTC
   
 
Severity:  2 - Normal Item Group:  Software
Status:  Fixed Privacy:  Public
Assigned to:  cederberg Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 28 May 2006 09:08:47 PM UTC, comment #2: 

Version 2.7 has now been released. Closing this bug.

Per Cederberg <cederberg>
Group administrator
Sun 23 Apr 2006 11:04:29 AM UTC, comment #1: 

This patch has now beed added to the SVN repository. It will be released in version 2.7.

Per Cederberg <cederberg>
Group administrator
Sun 23 Apr 2006 10:10:32 AM UTC, original submission:  

The ObjectIdentifierValue.toString() method makes recursive calls in order to create the OID string. This is not optimal for performance if the method is queried often.

Mohamed Ben Hedi Sghaier of Alcatel has contributed the following patch to address this issue:

private valueString=null;
public String toString() {
       if(valueString==null)
       {
           String tempValue;
           if (parent == null) {
               tempValue= String.valueOf(value);
           } else {
               tempValue= parent.toString() + "." + String.valueOf(value);
           }
           valueString=tempValue;
       }
       return valueString;
   }

Per Cederberg <cederberg>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

Follow 2 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-05-28 cederberg Open/ClosedOpen Closed
2006-04-23 cederberg StatusNone Fixed

Back to the top

Powered by Savane 3.13.
Corresponding source code