patchmldonkey, a multi-networks file-sharing client - Patches: patch #5235, Lock config_files_space.tmp and...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5235: Lock config_files_space.tmp and delete unused file on startup

Submitter:  spiralvoice <spiralvoice>
Submitted:  Mon 10 Jul 2006 06:00:29 PM UTC
   
 
Category:  Improved interfaces Priority:  5 - Normal
Status:  Done Assigned to:  None
Open/Closed:  Closed

Fri 14 Jul 2006 01:15:46 PM UTC, comment #3: 

Applied to CVS 2006/07/14

spiralvoice <spiralvoice>
Group administrator
Thu 13 Jul 2006 10:47:51 AM UTC, comment #2: 

Updated patch after successful tests on MinGW

spiralvoice <spiralvoice>
Group administrator
Tue 11 Jul 2006 08:44:59 AM UTC, comment #1: 

Working in debian testing(sid), details on:
http://mldonkey.sourceforge.net/forums/viewtopic.php?p=23345#23345

Fabiano <fabtar>
Mon 10 Jul 2006 06:00:29 PM UTC, original submission:  

This patch should resolve the problems when config_files_space.tmp
is a left-over from a previous crash of MLDonkey.
Now this file is kept open when MLDonkey core is running, so it
uses one file descriptor more than before, and locks it.
While this first MLDonkey is running a second one will fail to lock
the file on startup and therefore refuse to start.
If this second MLDonkey can lock config_files_space.tmp on startup
it will be deleted and MLDonkey starts normally.

This patch has to be tested on a lot of OS/distros & filesystems
if the lock is successful before it can be applied to CVS.
Start MLDonkey twice in the same dir, the second one should fail.
Then start MLDonkey once, copy config_files_space.tmp somewhere
safe, stop MLDonkey, copy config_files_space.tmp back and restart
MLDonkey, it should delete config_files_space.tmp on startup and
print a log message.

spiralvoice <spiralvoice>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10342:  5235.patch added by spiralvoice (8KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by smimram
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 7 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-07-14 spiralvoice StatusNone Done
        Open/ClosedOpen Closed
    2006-07-13 spiralvoice SummaryLock config_files_space.tmp and delete unsed file on startup Lock config_files_space.tmp and delete unused file on startup
        Attached File- Added 5235.patch, #10342
    2006-07-13 spiralvoice Attached File#10327 Removed
    2006-07-10 smimram Carbon-Copy- Added -email is unavailable-
    2006-07-10 spiralvoice Attached File- Added config_space.patch, #10327

    Back to the top

    Powered by Savane 3.13-caa5.
    Corresponding source code