mainSavannah Administration - Support: sr #110594, git push returns "hints"...

 
 

sr #110594: git push returns "hints" about ignored hooks

Submitter:  Bernhard Voelker <berny>
Submitted:  Mon 03 Jan 2022 12:39:47 AM UTC
   
 
Category:  Source code repositories - developer access Priority:  5 - Normal
Severity:  3 - Normal Status:  Duplicate
Privacy:  Public Assigned to:  rwp
Operating System:  GNU/Linux Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 03 Jan 2022 09:05:31 PM UTC, comment #3: 


> Anyway, I wonder if/how the hook scripts of older repositories ever get updated.
> Comparing a freshly initialized repository shows quite some differences,


They never get updated.  Until now git has always been backward
compatible.  This is notable in that it breaks backward compatibility.

However I think git upstream would say, it's only a "hint:" and
nothing is broken.  That's true.  But it's definitely a nag-message
that is there with the specific intention of making people change
something manually.  It's created quite the uproar among Savannah
users for example.  It's definitely not not-broken by this change.
Therefore even if it is just a spurious message it still breaks
backward compatibility IMNHO.

I have finished a first pass scrape across the entire collection of
repositories.  As one might imagine that over the years of spread
between the creation of them, and over the years of different
sysadmins making changes, there are variations.  All of the ones that
are the majority cases have been fixed to comply with the needs of the
current git version and do not have disabled hook scripts in place.
They were all moved to name.sample or name.datestamp type names to
avoid the spurious hint message.

That leaves a reduced list number of 139 that I need to review and
deal with next.

Bob Proulx <rwp>
Site Administrator
Mon 03 Jan 2022 07:52:14 AM UTC, comment #2: 

Hi Bob,

ouch, that's annoying, indeed.

Anyway, I wonder if/how the hook scripts of older repositories ever get updated.
Comparing a freshly initialized repository shows quite some differences,
e.g. the hook scripts in the new one are all ugo-x while all the files in
clones of older repositories are all ugo+x.

Thanks for the clarification.

Bernhard Voelker <berny>
Mon 03 Jan 2022 01:24:12 AM UTC, comment #1: 

Hi Berny,

Since this has been getting discussed in this other bug ticket I am going to reference it and close this one.  Feel free to add comments there.

https://savannah.nongnu.org/support/?110591

I'll summarize.

First: Ignore that "hint:" message about hooks.  Until we can clean things up across the 4643 git repositories.  It used to be that "git init" would install many hook scripts in place as samples.  They were never enabled because the file permissions were not executable.  They contained a comment that says:

# To enable this hook, make this file executable.

In between versions started creating repositories named with a foohook.sample type naming where in addition to changing permissions one would need to rename the file away from .sample too.  And so newer projects don't have those while older ones do.

The newer version of git that we moved to on the 24th with the new server now complains about those files that exist but are not executable.  Which is extremely annoying since they are reversing what they had previously done as a default.  They created thousands of those files and now they want to reverse that decision.  Grr...

Of course it is just some simple scripting to process all of those and fix things up.  And 'find' will be playing a huge good role in that scripting.  But this "hint:" issue was only reported yesterday and I haven't had the moment to do it yet.  But I will get to it soonest because I am sure everyone will be wondering about those new messages.

My plan is to preserve timestamps on files by renaming files rather than by editing config files.



Bob Proulx <rwp>
Site Administrator
Mon 03 Jan 2022 12:39:47 AM UTC, original submission:  

Since a couple of days, git outputs the following "hint" lines when
pushing to Savannah:


berny@blackice:~/findutils> git push sv
Enumerating objects: 261, done.
Counting objects: 100% (261/261), done.
Delta compression using up to 4 threads
Compressing objects: 100% (132/132), done.
Writing objects: 100% (136/136), 19.11 KiB | 3.82 MiB/s, done.
Total 136 (delta 111), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (111/111), completed with 110 local objects.
hint: The 'hooks/update' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
hint: The 'hooks/post-receive' hook was ignored because it's not set as executable.
hint: You can disable this warning with `git config advice.ignoredHook false`.
To ssh://git.sv.gnu.org/srv/git/findutils.git
   2efc2d2e..db5ec614  master -> master


It seems that the push was successful, but - as I heard that Savannah got new
hardware - is this something to worry about?

Thanks & have a nice day,
Berny

 Bernhard Voelker <berny>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rwp (Posted a comment)
  • -email is unavailable- added by berny (Submitted the item)

    •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2022-01-03 rwp StatusNone Duplicate
        Assigned toNone rwp
        Open/ClosedOpen Closed

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.14-8aba.
    Corresponding source code