bugGKSu - Bugs: bug #14881, libgksu: pty.h isn't portable

 
 

bug #14881: libgksu: pty.h isn't portable

Submitted by:  None
Submitted on:  Fri 28 Oct 2005 05:02:09 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: Gustavo Noronha Silva <kov>
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Aug 2006 06:53:31 PM UTC, comment #3:

Hey dmacks,

I am all for portability, but I don't have other systems available for testing, so I would welcome a patch tested in a system where pty.h is not available so I can merge it.

Thanks!

Gustavo Noronha Silva <kov>
Project AdministratorIn charge of this item.
Fri 28 Oct 2005 05:31:44 PM UTC, comment #2:

The original bug report is for libgksu-1.3.6.
comment #1 is for libgksu-1.3.6 and also gksu-1.3.6 (for its gksu/Makefile.am)

Daniel Macks <dmacks>
Fri 28 Oct 2005 05:13:01 PM UTC, comment #1:

(sorry, forgot to log in when I submitted this)

To continue with forkpty portability, libutil isn't always needed for it on non-glibc machines like OS X, which have a monolithic system lib instead of many different libfoo components. Better to use AC_CHECK_LIB to see if that lib is really needed (which automatically causes -lutil to be passed to the linker) instead of forcing -lutil in libgksu/Makefile.am

Daniel Macks <dmacks>
Fri 28 Oct 2005 05:02:09 PM UTC, original submission:

pty.h, which I assume is used to define for the forkpty() function, isn't always present; sometimes util.h is needed instead. How about adding AC_CHECK_HEADERS for these in configure.ac and patching libgksu/gksu-context.c something like:

+#include "../config.h"
+#if HAVE_PTY_H
#include <pty.h>
+#endif
+#if HAVE_UTIL_H
+#include <util.h>
+#endif

(and remove the #include "../config.h" later in that file)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

Please enter the title of George Orwell's famous dystopian book (it's a date):

 

 

Follow 2 latest changes.

Date Changed By Updated Field Previous Value => Replaced By
Mon 01 May 2006 02:53:51 PM UTCkovAssigned toNone=>kov
Fri 28 Oct 2005 05:13:01 PM UTCdmacksCarbon-Copy-=>Added dmacks

Back to the top


Powered by Savane 3.1-cleanup