bugAVR Downloader/UploaDEr - Bugs: bug #18339, safemode doesn't care for...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #18339: safemode doesn't care for pgm->read_byte() return values

Submitted by:  Joerg Wunsch <joerg_wunsch>
Submitted on:  Tue 21 Nov 2006 06:17:00 PM UTC  
 
Category:  None Severity:  3 - Normal
Priority:  5 - Normal Item Group:  None
Status:  None Privacy:  Public
Assigned to:  Colin O Flynn <c_oflynn> Originator Name:  Joerg Wunsch
Open/Closed:  Closed Release:  None
Programmer hardware:  Device type: 

Mon 11 Dec 2006 02:45:04 PM UTC, comment #3:

Changes are in CVS.

It's sort a hack ;-) Based on how I did the original code, I thought it was the safest and cleanest way to add that feature. This way the error is the same as if you didn't have a reliable programmer, which to me makes sense as that function failing.

-Colin

(file #11505)

Colin O Flynn <c_oflynn>
Project MemberIn charge of this item.
Mon 11 Dec 2006 02:24:33 PM UTC, comment #2:

Seems a bit like a hack to me :), but OK, the implementation
is yours anyway, so please go ahead and commit it.

Joerg Wunsch <joerg_wunsch>
Project Administrator
Tue 21 Nov 2006 08:33:00 PM UTC, comment #1:

Ooops - quite the oversight!

See attached patch - does it work for you? It uses the idea that safemode doesn't care what the returned values are, only if they are the same or different.

So to make sure, if any function retursn anything other than 0 it makes sure the nonsense returned is DIFFERENT nonsense.

-Colin

Colin O Flynn <c_oflynn>
Project MemberIn charge of this item.
Tue 21 Nov 2006 06:17:00 PM UTC, original submission:

The safemode code doesn't care for the values returned by
pgm->read_byte(), and in case of a failure, happily continues
using whatever results these functions might (or might not)
have returned as values (not) read from the fuse memory
region(s).

Joerg Wunsch <joerg_wunsch>
Project Administrator

 

Attached Files
file #11505:  safemode_patch.diff added by c_oflynn (4KiB - text/x-patch - Attached patch is in CVS (I deleted the patch from this tracker by accident which is why it's reattached))

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by c_oflynn (Updated the item)
  • -email is unavailable- added by joerg_wunsch (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2006-12-11 c_oflynn Attached File- => Added safemode_patch.diff, #11505
        Open/ClosedOpen => Closed
    2006-12-11 c_oflynn Attached File#11310 => Removed
    2006-11-21 c_oflynn Attached File- => Added safemode_patch.diff, #11310
    2006-11-21 joerg_wunsch Carbon-Copy- => Added -email is unavailable-

    Back to the top


    Powered by Savane 3.4