bugBongo - Bugs: bug #18628, Broken sectioning: Bongo fails to...

 
 

bug #18628: Broken sectioning: Bongo fails to join albums with just two tracks (maybe?)

Submitter:  Daniel Brockman <dbrock>
Submitted:  Fri 29 Dec 2006 08:34:52 AM UTC
   
 
Category:  None Severity:  4 - Important
Item Group:  None Status:  Fixed
Privacy:  Public Assigned to:  dbrock
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 06 Apr 2007 01:46:14 PM UTC, comment #9: 

Confirmed that it works.

Daniel Jensen <djensen>
Group Member
Fri 06 Apr 2007 01:11:05 PM UTC, comment #8: 

Ah, I shouldn’t have tried it only in empty buffers.

I have installed a patch (“Introduce `bongo-bind-field-values'”) which I believe fixes this bug.

Daniel Brockman <dbrock>
Group administrator
Thu 05 Apr 2007 01:52:26 PM UTC, comment #7: 

Sure. I found that the bug does not occur when tracks are joined at the top of the buffer.

Here is a test case:

/tmp/A - A - 01 - A.ogg
/tmp/A - A - 02 - A.ogg
/tmp/B - Bar - 01 - B.ogg
/tmp/B - Bar - 02 - B.ogg
/tmp/B - Foo - 01 - B.ogg
/tmp/B - Foo - 02 - B.ogg

Daniel Jensen <djensen>
Group Member
Thu 05 Apr 2007 01:36:48 AM UTC, comment #6: 

I don't see this bug.  Can you provide a list of file names that provokes it?

Daniel Brockman <dbrock>
Group administrator
Wed 04 Apr 2007 10:27:12 AM UTC, comment #5: 

Mr. Bongo, this bug needs to be fixed!

I tried to debug it, but it's giving me a headache. I can't convince myself that `bongo-region-joinable-on-field-p' is wrong. Maybe it is not called correctly?

The only thing I have made sure is that it is exactly your patch that introduced the new bug (while fixing the old one, of course).

Daniel Jensen <djensen>
Group Member
Sat 03 Mar 2007 09:25:49 PM UTC, comment #4: 

Yes, I see the same bug here.

Romain Francoise <rfrancoise>
Group Member
Wed 07 Feb 2007 02:27:45 PM UTC, comment #3: 

It looks like your patch fixes the problem. Hoewver, I have spotted another sectioning bug. I don't know how it's related to your fix, but I'll report it here.

I have Bongo set to insert intermediate headers. Here's an example of what's wrong.

The section is supposed to look like this:


 [Artist]
    [Album1]
      Track1
      ...
    [Album2]
      Track1
      ...


Instead, it looks like this:


 [Artist - Album1]
      Track1
      ...
    [Album2]
      Track1
      ...


Daniel Jensen <djensen>
Group Member
Tue 06 Feb 2007 11:12:21 PM UTC, comment #2: 

I believe this patch fixes the problem.

(file #11934)

Daniel Brockman <dbrock>
Group administrator
Tue 02 Jan 2007 11:18:31 PM UTC, comment #1: 

I can confirm that this is most probably a glitch with two-track albums. I'm guessing this was introduced in Darcs patch 20061208144650, but I haven't been able to debug it.

Daniel Jensen <djensen>
Group Member
Fri 29 Dec 2006 08:34:52 AM UTC, original submission:  

Romain described this bug as follows:

I have a directory tree (created with tree-from-tags.rb) that looks like this:


$ find Godspeed\ You\ Black\ Emperor/ -type d
Godspeed You Black Emperor/
Godspeed You Black Emperor/Godspeed You Black Emperor - 1999 - Slow Riot For New Zero Kanada
Godspeed You Black Emperor/Godspeed You Black Emperor - 2000 - Lift Your Skinny Fists Like Antennas to Heaven


It used to be inserted like this in the buffer:


[Godspeed You Black Emperor]
  [Slow Riot For New Zero Kanada (1999)]
    01. Moya
    02. Bbf3
  [Lift Your Skinny Fists Like Antennas to Heaven (2000)]
    01. Storm
    02. Gathering Storm
    03. Sleep
    04. Antennaes To Heaven


and now it's like this:


[Godspeed You Black Emperor]
  Slow Riot For New Zero Kanada (1999) -- 01. Moya
  Slow Riot For New Zero Kanada (1999) -- 02. Bbf3
  Lift Your Skinny Fists Like Antennas to Heaven (2000) -- 01. Storm
  Lift Your Skinny Fists Like Antennas to Heaven (2000) -- 02. Gathering Storm
  Lift Your Skinny Fists Like Antennas to Heaven (2000) -- 03. Sleep
  Lift Your Skinny Fists Like Antennas to Heaven (2000) -- 04. Antennaes To Heaven


Oddly enough, the bug occurs for only a few directories, not all.
I haven't found what's the factor to trigger it, unfortunately.

Daniel Brockman <dbrock>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #11934:  bug-18628-fix.patch added by dbrock (626B - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rfrancoise (Posted a comment)
  • -email is unavailable- added by djensen (Posted a comment)
  • -email is unavailable- added by dbrock (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-04-06 djensen StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2007-04-06 dbrock StatusNeed Info Ready For Test
    2007-04-05 dbrock Severity3 - Normal 4 - Important
        StatusReady For Test Need Info
    2007-02-06 dbrock Attached File- Added bug-18628-fix.patch, #11934
        StatusConfirmed Ready For Test
        Assigned toNone dbrock
    2007-01-02 djensen StatusNone Confirmed
    2006-12-29 dbrock Carbon-Copy- Added rfrancoise

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code