bugBibORB - Bugs: bug #20219, Localization of $GET['mode'] value

 
 

bug #20219: Localization of $GET['mode'] value

Submitter:  None
Submitted:  Wed 20 Jun 2007 10:54:39 AM UTC
   
 
Category:  Internationalization Severity:  3 - Normal
Item Group:  Errors Status:  None
Assigned to:  None Open/Closed:  Open
Release:  * 1.3.3 Fixed Release:  None
Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 20 Jun 2007 11:01:13 AM UTC, comment #1: 

Read msg('Select') instead of msgstr('Select')...

Anonymous
Wed 20 Jun 2007 10:54:39 AM UTC, original submission:  

In bibindex.php, there is a msgstr('Select') case within the switch($mode). This results in not matching the case if that message string contains html special characters. A hot fix is to strip html special characters. A much better solution is to not localize $GET values at all:

In bibindex.php, change

  case msgstr('Select'):

to

  case 'Select':

and in php/interface-bibindex.php, function bibindex_entry_to_add() instead of

  $content .= "&nbsp;<input class='submit' type='submit' name='mode' id='mode' value='".msg("Select")."'/>";

insert a hidden input which sets the mode value:

  $content .= "<input name='mode' id='mode' value='Select' type='hidden'>";
  $content .= "&nbsp;<input class='submit' type='submit' value='".msg("Select")."'/>";

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

Only logged-in users can vote.

 

No changes have been made to this item

Back to the top

Powered by Savane 3.13-caa5.
Corresponding source code