bugQuilt - Bugs: bug #20628, Quilt checks for duplicate patches...

 
 

bug #20628: Quilt checks for duplicate patches circumvented if using a generated series file

Submitted by:  None
Submitted on:  Mon 30 Jul 2007 05:48:44 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: Jean Delvare <khali>
Open/Closed: Closed

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 02 Mar 2014 12:13:32 PM UTC, comment #3:

Fix committed:

http://git.savannah.gnu.org/cgit/quilt.git/commit/?id=6c9a83e0cb98eb6023269c620c528466796e1c25

Jean Delvare <khali>
Project AdministratorIn charge of this item.
Fri 28 Feb 2014 09:27:14 AM UTC, comment #2:

The first candidate fix is bad performance-wise. We call grep and sed for every patch we check, and the list we grep grows with every patch we apply, making it an O(n^2) algorithm.

I benchmarked this patch on a very large patch series (14805 patches) and "quilt push -qa" took ~25% more time to complete. This is hardly acceptable.

Meanwhile I came up with a smarter and faster way to check for duplicate patches in series, I'll attach it.

Jean Delvare <khali>
Project AdministratorIn charge of this item.
Wed 26 Feb 2014 02:56:32 PM UTC, comment #1:

The problem is still present in version 0.61, and I agree it should be addressed.

Jean Delvare <khali>
Project AdministratorIn charge of this item.
Mon 30 Jul 2007 05:48:44 AM UTC, original submission:

If using quilt with a guards generated series file the normal
checks to prevent a patch with the same name being created are
circumvented.

While this is not a problem with quilt it would be nice if quilt
prevented the attempt to push an existing patch and issued a warning.

Quilt commands get very confused when this happens and it can be
tricky to recover from.

$ quilt --version
0.46

--
Donald

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #30731:  quilt-push-check-applied-2.patch added by khali (2kB - text/x-patch - Second candidate fix)
file #30714:  quilt-push-check-applied.patch added by khali (2kB - text/x-patch - Candidate fix)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by khali (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 02 Mar 2014 12:13:32 PM UTCkhaliStatusConfirmed=>Fixed
      Open/ClosedOpen=>Closed
    Fri 28 Feb 2014 09:28:11 AM UTCkhaliAttached File-=>Added quilt-push-check-applied-2.patch, #30731
    Wed 26 Feb 2014 08:03:28 PM UTCkhaliAttached File-=>Added quilt-push-check-applied.patch, #30714
    Wed 26 Feb 2014 02:56:32 PM UTCkhaliStatusNone=>Confirmed
      Assigned toNone=>khali

    Back to the top


    Powered by Savane 3.1-cleanup