bugAVR Downloader/UploaDEr - Bugs: bug #21076, -vvvv serial receive prints are...


You are not allowed to post comments on this tracker with your current authentication level.

bug #21076: -vvvv serial receive prints are empty in Win32 build

Submitted by:  Joerg Wunsch <joerg_wunsch>
Submitted on:  Fri 14 Sep 2007 09:04:36 AM UTC  
Category:  None Severity:  5 - Blocker
Priority:  9 - Immediate Item Group:  None
Status:  Fixed Privacy:  Public
Assigned to:  Eric Weddington <arcanum> Originator Name:  Joerg Wunsch
Open/Closed:  Closed Release:  None
Programmer hardware:  Device type: 

Mon 29 Oct 2007 11:12:06 PM UTC, comment #3:

Confirmed this fixes it - old version of avrdude had the bug, newly checked out CVS did not. Cha-Ching.

Colin O Flynn <c_oflynn>
Project Member
Mon 29 Oct 2007 09:52:31 PM UTC, comment #2:

I've chosen a different way to fix it than in the suggested

Eric, please close the bug after verifying it really does the
job -- but I'm pretty positive it does, after reading the
MSDN documentation for ReadFile().

Joerg Wunsch <joerg_wunsch>
Project Administrator
Fri 14 Sep 2007 02:47:02 PM UTC, comment #1:

Eric, curious, since you uploaded a patch, I assume this means
you've already tested it? That would be great, I could only
have fixed it blindly myself.

Joerg Wunsch <joerg_wunsch>
Project Administrator
Fri 14 Sep 2007 09:04:36 AM UTC, original submission:

It turns out the variable "len" which is used to control the
loop is never assigned.

Good item to demonstrate why you'd rather not blindly
initialize all local variables by default in their definition,

static int ser_recv(union filedescriptor fd, unsigned char buf, size_t buflen)
unsigned char c;
unsigned char * p = buf;
size_t len = 0;

Joerg Wunsch <joerg_wunsch>
Project Administrator


Attached Files
file #13943:  avrdude-bug-21076.patch added by arcanum (437B - application/octet-stream - Untested patch.)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by c_oflynn (Posted a comment)
  • -email is unavailable- added by arcanum (Updated the item)
  • -email is unavailable- added by joerg_wunsch (Submitted the item)

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.




    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2007-10-29 c_oflynn Open/ClosedOpen => Closed
    2007-10-29 joerg_wunsch StatusNone => Fixed
    2007-09-14 arcanum Assigned toNone => arcanum
    2007-09-14 arcanum Severity3 - Normal => 5 - Blocker
        Priority5 - Normal => 9 - Immediate
    2007-09-14 arcanum Attached File- => Added avrdude-bug-21076.patch, #13943

    Back to the top

    Powered by Savane 3.3