bugCERTI - Bugs: bug #24420, getRegionToken() and getRegion()...

 
 

bug #24420: getRegionToken() and getRegion() not implemented

Submitted by:  Petr Gotthard <gotthardp>
Submitted on:  Wed 01 Oct 2008 07:51:02 AM UTC  
 
Category: CERTISeverity: 2 - Minor
Item Group: HLA compliance errorStatus: In Progress
Privacy: PublicAssigned to: Petr Gotthard <gotthardp>
Open/Closed: ClosedRelease: CVS
Reproducibility: Every TimeFixed Release: 3.4.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 11 Nov 2010 12:16:49 PM UTC, comment #6:

From the source code I would bet
this is done.

Closing the bug.

Eric NOULARD <erk>
Project Administrator
Fri 03 Oct 2008 07:48:43 AM UTC, comment #5:

I found the description in the DoD's HLA RTI 1.3 Programmer's Guide version 3.2 (section A.7.27 and A.7.28).

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Thu 02 Oct 2008 08:24:22 PM UTC, comment #4:

I did not touch or look at the DDM code so that
I may not be very responsive...
May be Pierre may be faster than me on this I add him as CC.

Concerning your patch I agree this one seems OK,
my opinion is you may apply it.
However where did you find the spec for the missing

getRegionToken()
getRegion()

Regarding DDM you'll find most of the code in
RTIA/DataDistribution
Concerning memory management you are right deleteRegion
should only be called once.
If ever a federate call it twice then
RTI::RTIambassador::deleteRegion
should throw "RegionNotKnown".

If you go further on this it would be nice to
add may be a "regionTest" to the HLA_TestsSuite which
may enhanced our test suite and validate the
newly implemented API.

However as usual with OSS it's a wish :=)

Eric NOULARD <erk>
Project Administrator
Thu 02 Oct 2008 02:27:37 PM UTC, comment #3:

Hello. I found that PyHLA needs these methods, so I assigned this task to myself. ;-) However, I would appreciate your guidance.

These methods are expected to convert the internal regionHandle to the Region* (and vice versa).

(1) The getRegionToken() is an easy task. Do you agree with the attached patch?

(2) The getRegion() would need a list of all Region*'s. Is this list somewehere available to the federate?
We should also consider memory management. I think that there should be only one Region* instance and thus the deleteRegion() should be called only once, regardless how many getRegion calls were before. Right?
[There will be a similar problems once the attributeValueSet.getregion() calls are implemented. I haven't found any note in HLA1.3 regarding who is supposed to delete that memory.]

(file #16600)

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Thu 02 Oct 2008 09:54:55 AM UTC, comment #2:

Empty implementation is now stored in CVS. A DLC compliant application will compile with CERTI, but fail when one of these methods is invoked.

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Wed 01 Oct 2008 01:38:11 PM UTC, comment #1:

See the ML thread concerning DLC:
http://lists.nongnu.org/archive/html/certi-devel/2008-10/msg00000.html

Eric NOULARD <erk>
Project Administrator
Wed 01 Oct 2008 07:51:02 AM UTC, original submission:

The getRegionToken() and getRegion() method need to be implemnted for DLC API compliancy.

See also bug #23188.

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16600:  patch.diff added by gotthardp (937B - text/x-patch - getRegionToken() implementation)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by erk (Request for comment)
  • -unavailable- added by erk (Posted a comment)
  • -unavailable- added by gotthardp (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 11 Nov 2010 12:16:49 PM UTCerkOpen/ClosedOpen=>Closed
      Fixed ReleaseUnknown=>3.4.0
    Wed 05 Nov 2008 01:03:13 PM UTCerkDependencies-=>bugs #24753 is dependent
    Wed 05 Nov 2008 01:02:52 PM UTCerkStatusNone=>In Progress
    Thu 02 Oct 2008 08:24:22 PM UTCerkCarbon-Copy-=>Added siron
    Thu 02 Oct 2008 02:27:37 PM UTCgotthardpAttached File-=>Added patch.diff, #16600
      Assigned toNone=>gotthardp

    Back to the top


    Powered by Savane 3.1-cleanup