bugCERTI - Bugs: bug #24763, XPlane-Plugin compilation errors

 
 

bug #24763: XPlane-Plugin compilation errors

Submitted by:  Petr Gotthard <gotthardp>
Submitted on:  Thu 06 Nov 2008 04:59:43 PM UTC  
 
Category: XPlaneHLA_PluginSeverity: 5 - Blocker
Item Group: Compilation errorStatus: Fixed
Privacy: PublicAssigned to: Petr Gotthard <gotthardp>
Open/Closed: ClosedRelease: CVS
Reproducibility: Every TimeFixed Release: NextRelease

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Fri 06 Dec 2013 12:26:45 PM UTC, comment #8:

Closing oldish bugs.
Will be reopened if needed?

Eric NOULARD <erk>
Project Administrator
Tue 15 Dec 2009 07:09:21 PM UTC, comment #7:

All of the initially reported issues are now fixed.

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Tue 15 Dec 2009 07:03:37 AM UTC, comment #6:

Hi Petr,

No problem, Go ahead.
None of us is currently working on this currently.
moreove I trust you for good fixes :-)

Eric NOULARD <erk>
Project Administrator
Mon 14 Dec 2009 11:30:27 PM UTC, comment #5:

Let's start fixing the X-Plane plug-in. ;-)

Eric, as as first step I would propose to enhance the FindXPlane.cmake script to make the plug-in compilable (see attachement). May I commit?

(file #19268, file #19269, file #19270)

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Thu 06 Nov 2008 10:40:46 PM UTC, comment #4:

I have switches HLA_TestsSuite and HLA_Tutorial
to FindRTI (instead of FindCERTI).

Concerning XPlane-Plugin I may not be able
to go on with it until next week.

Concerning INCLUDE_DIRECTORIES

the FindXPlane.cmake does it (lines 70 & 87),
even if if should not :-(

for RTI INCLUDE(UseCERTI) does it,
but your are right it should be replaced with
FIND_PACKAGE(RTI REQUIRED)
INCLUDE_DIRECTORIES(${RTI_INCLUDE_DIR})
ADD_DEFINITIONS(${RTI_DEFINITIONS})

Eric NOULARD <erk>
Project Administrator
Thu 06 Nov 2008 10:31:40 PM UTC, comment #3:

No you won't interfere.
If ever you do be sure I will tell you,
however I will always commit faster than you :=)
Just kidding ;-)

Contributions rules do apply for XPlane-Plugin too,
(or any other CERTI@Savannah hosted module).

1) patches are alaways welcome :=)
2) commit should be asked to the maintainer of the module
or to certi admin if no one else is available.

Concerning the plugin I won't always be able to build & test
on a Windows box with XPlane so I may only read the patch
before accepting commit from a trusted contributor, i.e.
one who have commit right :-).

My next step regarding XPlane-Plugin will be to setup
a systematic build (may be with a new Dashboard).

Eric NOULARD <erk>
Project Administrator
Thu 06 Nov 2008 10:08:29 PM UTC, comment #2:

Thanks, Eric. I didn't want to interfere with your development. If the development is dormant for the time being, I may help with this issue.
Do the same contribution rules as for CERTI apply also to the XPlane-Plugin?

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.
Thu 06 Nov 2008 08:09:01 PM UTC, comment #1:

Hi Petr,

I agree on all what is said here.
However as you may have guess I'm not really from the
Windows-side of the world :=)

So I have have far less time to work Windows work.
Jean-Michel who was working on XPlane plugin
have to switch to another task for which he need
to be at 100%...

I will find time to switch all Federate examples
(HLA_Tutorial, HLA_TestsSuite and XPlaneHLAPlugin)
from FindCERTI to FindRTI.

I'll try to make some "blind" modifications for other
issue.
I will try to find someone else who is more
of the "windows side" of the world for the long term :=)

Eric NOULARD <erk>
Project Administrator
Thu 06 Nov 2008 04:59:43 PM UTC, original submission:

Hello. There is a bunch of issues witth the XPlane-Plugin configuration and compilation.
- cmake modules to find include directory should use FIND_PATH instead of FIND_FILE (in FindXPlane.cmake)
- the paths detected by .cmake (both RTI and XPlane) are not mentioned in INCLUDE_DIRECTORIES, so the compiler cannot find headers
- I also suggest to avoid depenency on CERTI.cmake: replace by FindRTI and duplicate the MESSAGE_QUIETLY macro [it's not such a big deal and you might gain compatibility with other RTI].

Petr Gotthard <gotthardp>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #19270:  XP_Init.cpp added by gotthardp (7kB - text/x-c - XPlane_Trace\XP_Init.cpp)
file #19268:  CMakeLists.txt added by gotthardp (4kB - text/plain - XPlane_Trace\XP_Init.cpp)
file #19269:  FindXPlane.cmake added by gotthardp (2kB - application/octet-stream - XPlane_Trace\XP_Init.cpp)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by erk (Posted a comment)
  • -unavailable- added by gotthardp (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 06 Dec 2013 12:26:45 PM UTCerkStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 15 Dec 2009 07:15:58 PM UTCgotthardpDependencies-=>bugs #26818 is dependent
    Tue 15 Dec 2009 07:09:21 PM UTCgotthardpStatusIn Progress=>Ready For Test
    Mon 14 Dec 2009 11:30:27 PM UTCgotthardpAssigned toNone=>gotthardp
      StatusNone=>In Progress
      Attached File-=>Added CMakeLists.txt, #19268
      Attached File-=>Added XP_Init.cpp, #19270
      Attached File-=>Added FindXPlane.cmake, #19269

    Back to the top


    Powered by Savane 3.1-cleanup