bugPingus - Bugs: bug #30022, SConscript broken using...

 
 

bug #30022: SConscript broken using with_linuxevdev=0

Submitter:  None
Submitted:  Tue 01 Jun 2010 03:49:09 AM UTC
   
 
Category:  General Stuff Severity:  3 - Normal
Item Group:  Installation Problem Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  SVN
Operating System:  All Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Tue 01 Jun 2010 03:50:36 AM UTC, comment #1: 

Sorry, I thought I was logged in when I submitted the bug.

Benn Newman <newmanbe>
Tue 01 Jun 2010 03:49:09 AM UTC, original submission:  

SConscript has two problems with building without evdev support:

1) reports += "  * Linux evdev support: disabled\n" # should be self.reports

2) Scons still attempts to build the tests for evdev, even if evdev support is disabled; this fails on NetBSD (and other systems, I imagine) even though the pingus still otherwise works.

SConscript.patch fixes the first problem.

The second problem can be changed by changing (line 343)

    for filename in Glob("test/*_test.cpp", strings=True):
        self.env.Program(filename[:-4], [filename, libpingus])

to something like

    for filename in Glob("test/*_test.cpp", strings=True):
        if(self.config_h_defines != ('HAVE_LINUXEVDEV', 1) and filename != 'test/evdev_device_test.cpp)
            self.env.Program(filename[:-4], [filename, libpingus])

but I do not understand Python and scons enough to know exactly what. (I just commented out those two lines.)

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #20669:  SConscript.patch added by None (520B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by grumbel (Updated the item)
  • -email is unavailable- added by newmanbe (Posted a comment)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-08-31 grumbel StatusNone Fixed
        Open/ClosedOpen Closed
    2010-06-01 None Attached File- Added SConscript.patch, #20669

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code