bugacl - Bugs: bug #30840, perm_copy_file can fail if...

 
 

bug #30840: perm_copy_file can fail if acl_delete_def_file fails with ENOTSUP

Submitted by:  None
Submitted on:  Sun 22 Aug 2010 04:42:00 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Item Group: NoneStatus: None
Privacy: PublicAssigned to: None
Open/Closed: Open

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 24 Aug 2010 02:21:20 AM UTC, comment #1:

This comment has been made anonymously so we may never get a reply, but anyway ...

How did you trace this to perm_copy_file()? Are you sure this is not about copying the selinux labels? Can you show how this looks in ltrace?

Note that it's normal to get an error message if some permission information cannot be preserved here; only if no information is lost will there be no error.

> It looks like the code in perm_copy_file.c is not checking for
> ENOTSUP if acl_delete_def_file() fails, unlike the
> acl_set_file() call.


This is after acl_set_file() has succeeded, in which case we can safely assume that acl_delete_def_file() will be supported as well.

> (The error checks after the chmod() call after acl_set_file()
> fails are a bit off too - the ret value from chmod() isn't
> checked, and saved_errno should be checked.)


Thanks, this should indeed be fixed.

Andreas Gruenbacher <agruen>
Project Administrator
Sun 22 Aug 2010 04:42:00 PM UTC, original submission:

Hi -

I'm running current Fedora 13 with libacl-2.2.49-6

When I run adduser, I get this failure:

adduser: preserving permissions for /home/tool/.mozilla: Operation not supported

It looks like the code in perm_copy_file.c is not checking for ENOTSUP if acl_delete_def_file() fails, unlike the acl_set_file() call.

(The error checks after the chmod() call after acl_set_file() fails are a bit off too - the ret value from chmod() isn't checked, and saved_errno should be checked.)

I was originally running with selinux enabled, but it's now disabled, plus my /home directory was not modified by my recent install of Fedora 13.

So, I assume my /etc/skel files have some sort of acl, but those aren't supported under /home.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by agruen (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item

    Back to the top


    Powered by Savane 3.1-cleanup