bugPingus - Bugs: bug #33744, SVN source won't build

 
 

bug #33744: SVN source won't build

Submitter:  Anders Skogheim Liane <maneatingduck>
Submitted:  Sun 10 Jul 2011 07:09:01 PM UTC
   
 
Category:  General Stuff Severity:  3 - Normal
Item Group:  Installation Problem Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  SVN
Operating System:  Linux Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sat 16 Jul 2011 04:32:50 PM UTC, comment #2: 

just for further info this confirms what maneatingduck found!

1) you do need to mkdir or the build fails

2) you have to do scons src then scons

3) the files in src/engine/system/ are never compiled  as maneatingduck added the single file "sdl_system.cpp" but i have added the following line to SconScript line 239 so all cpp files in there get compiled

Glob('src/engine/system/*.cpp') + \

(there is only one at the moment so it doesnt make any difference but saves problems later if someone adds another .cpp file there!)


Kev

Kevin <colintreebush>
Thu 14 Jul 2011 05:40:00 PM UTC, comment #1: 

this patch is great i am a programmer lol) how do we go about getting it added to the main source?

I just made this change myself on my local copy.  Who controls access to cvs on this project? 

Thanks

Kevin <colintreebush>
Sun 10 Jul 2011 07:09:01 PM UTC, original submission:  

When I checked out the source from svn://svn.berlios.de/pingus/trunk/pingus/ the build failed. There were two problems; the build directory would not be created, and src/engine/system/sdl_system.cpp was not compiled, leading to build errors.

I've included a patch which corrects those problems. I added sdl_system.cpp to the optional_sources list, and added mkdir -p build and scons src to Makefile. I also took the liberty of adding the option -j 6 to scons, I don't believe there are good reasons not to use multiple jobs for building? The speedup on a multicore system is significant.

I'm not a programmer by trade, I apologise if my patch is not optimal :)

Anders Skogheim Liane <maneatingduck>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by grumbel (Updated the item)
  • -email is unavailable- added by colintreebush (Posted a comment)
  • -email is unavailable- added by maneatingduck (Submitted the item)
  • -email is unavailable- added by maneatingduck (Så får vi se :))
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-08-27 grumbel StatusNone Fixed
        Open/ClosedOpen Closed
    2011-07-10 maneatingduck Attached File- Added pingus_build_settings.patch, #23635
        Carbon-Copy- Added -email is unavailable-

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code